Skip to content
Commit 093d27bb authored by Dorian Rudolph's avatar Dorian Rudolph Committed by Sebastian Reichel
Browse files

power: supply: core: Fix boundary conditions in interpolation

The functions power_supply_temp2resist_simple and power_supply_ocv2cap_simple
handle boundary conditions incorrectly.
The change was introduced in a4585ba2


("power: supply: core: Use library interpolation").
There are two issues: First, the lines "high = i - 1" and "high = i" in ocv2cap
have the wrong order compared to temp2resist. As a consequence, ocv2cap
sets high=-1 if ocv>table[0].ocv, which causes an out-of-bounds read.
Second, the logic of temp2resist is also not correct.
Consider the case table[] = {{20, 100}, {10, 80}, {0, 60}}.
For temp=5, we expect a resistance of 70% by interpolation.
However, temp2resist sets high=low=2 and returns 60.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarDorian Rudolph <mail@dorianrudolph.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Fixes: a4585ba2

 ("power: supply: core: Use library interpolation")
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 80192eff
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment