Skip to content
  1. Oct 30, 2019
  2. Oct 29, 2019
  3. Oct 26, 2019
  4. Oct 24, 2019
    • Tom Deadman's avatar
      Improved request errors (#286) · 35f2ae9a
      Tom Deadman authored
      
      
      * worked on wrapping errors in requests.go, added defer statements
      
      * removed .idea (generated by goland)
      
      * added another require.NoError
      
      * Update pkg/requests/requests.go
      
      Co-Authored-By: default avatarDan Bond <pm@danbond.io>
      
      * fixed out-of-order imports
      
      * changelog entry added
      
      * swapped error definitions to use fmt.Errorf rather than Wrap()
      
      * formatting changes, added new defers to requests_test.go
      
      * suppot for go1.12 pipeline removed from travis pipeline, .idea/ added to gitignore
      
      * Reorder changelog entry
      35f2ae9a
  5. Oct 22, 2019
  6. Oct 18, 2019
  7. Oct 17, 2019
  8. Oct 14, 2019
  9. Oct 10, 2019
  10. Oct 09, 2019
    • Kirill Motkov's avatar
      Some code improvements · e64e6fa5
      Kirill Motkov authored
      * Remove shadowing of predeclared identifier: new.
      * strings.ReplaceAll instead of strings.Replace with -1.
      * Change strings.ToLower comparison to strings.EqualFold.
      * Rewrite if-else-if-else chain as a switch.
      e64e6fa5
  11. Oct 08, 2019
  12. Oct 04, 2019
  13. Oct 03, 2019
  14. Oct 02, 2019
    • leyshon's avatar
      Merge branch 'master' into feature/azure-idtoken · d8d4c687
      leyshon authored
      d8d4c687
    • Joel Speed's avatar
      Merge pull request #269 from YenTheFirst/escape-k8s-auth-signin · 49f1320b
      Joel Speed authored
      Escape original request URI in sample kubernetes ingress configuration
      49f1320b
    • T S's avatar
      Escape original request URI in sample kubernetes ingress configuration · 513af9b7
      T S authored
      The current sample configuration for kubernetes ingress demonstrates
      using the `auth-signin` annotation to redirect a user to oauth2_proxy's
      signin page. It constructs the link to do so by directly concatenating
      `$request_uri` as the `rd` parameter, so the sign-in page knows where to
      send the user after signin is complete.
      
      However, this does not work correctly if the original request URI
      contains multiple query parameters separated by an ampersand, as that
      ampersand is interpereted as separating query parameters of the
      `/oauth2/start` URI. For example:
      
      If the user requests a URL:
        https://example.com/foo?q1=v1&q2=v2
      they may be redirected to the signin url
        https://example.com/oauth2/start?rd=https://example.com/foo?q1=v1&q2=v2
      and after completing signin, oauth2_proxy will redirect them to
        https://example.com/foo?q1=v1
      
      nginx-ingress added an $escaped_request_uri variable about a year ago,
      to help resolve this kind of issue
      (https://github.com/kubernetes/ingress-nginx/pull/2811)
      513af9b7