Skip to content
  1. Oct 10, 2019
  2. Oct 09, 2019
    • Kirill Motkov's avatar
      Some code improvements · e64e6fa5
      Kirill Motkov authored
      * Remove shadowing of predeclared identifier: new.
      * strings.ReplaceAll instead of strings.Replace with -1.
      * Change strings.ToLower comparison to strings.EqualFold.
      * Rewrite if-else-if-else chain as a switch.
      e64e6fa5
  3. Oct 08, 2019
  4. Oct 04, 2019
  5. Oct 03, 2019
  6. Oct 02, 2019
    • Joel Speed's avatar
      Merge pull request #269 from YenTheFirst/escape-k8s-auth-signin · 49f1320b
      Joel Speed authored
      Escape original request URI in sample kubernetes ingress configuration
      49f1320b
    • T S's avatar
      Escape original request URI in sample kubernetes ingress configuration · 513af9b7
      T S authored
      The current sample configuration for kubernetes ingress demonstrates
      using the `auth-signin` annotation to redirect a user to oauth2_proxy's
      signin page. It constructs the link to do so by directly concatenating
      `$request_uri` as the `rd` parameter, so the sign-in page knows where to
      send the user after signin is complete.
      
      However, this does not work correctly if the original request URI
      contains multiple query parameters separated by an ampersand, as that
      ampersand is interpereted as separating query parameters of the
      `/oauth2/start` URI. For example:
      
      If the user requests a URL:
        https://example.com/foo?q1=v1&q2=v2
      they may be redirected to the signin url
        https://example.com/oauth2/start?rd=https://example.com/foo?q1=v1&q2=v2
      and after completing signin, oauth2_proxy will redirect them to
        https://example.com/foo?q1=v1
      
      nginx-ingress added an $escaped_request_uri variable about a year ago,
      to help resolve this kind of issue
      (https://github.com/kubernetes/ingress-nginx/pull/2811)
      513af9b7
  7. Oct 01, 2019
  8. Sep 26, 2019
  9. Sep 20, 2019
  10. Aug 28, 2019
  11. Aug 21, 2019
  12. Aug 18, 2019
  13. Aug 17, 2019
  14. Aug 16, 2019
  15. Aug 15, 2019
  16. Aug 14, 2019
  17. Aug 13, 2019