Skip to content
Commit 3793662b authored by Alexander Kanavin's avatar Alexander Kanavin Committed by Steve Sakoman
Browse files

oeqa/qemurunner: do not use Popen.poll() when terminating runqemu with a signal

This does not actually guarantee that the child runqemu process has completely exited:
poll() may return prematurely while the SIGTERM handler in runqemu is still running.
This thwarts the rest of the processing, and may terminate the handler before
it completes.

Use Popen.communicate() instead: this is what python documentation recommends as well:
https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate



Signed-off-by: default avatarAlexander Kanavin <alex@linutronix.de>
Signed-off-by: default avatarRichard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit cd3e5560)
Signed-off-by: default avatarSteve Sakoman <steve@sakoman.com>
parent 85cb9212
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment