- Mar 18, 2023
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC clank-build@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: clank-library-failures@google.com Change-Id: I6cfc1fe52e9fd79ec79af910737b6c79e9b59f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4349803 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1118950}
-
Thuong Phan authored
Displays the color options for each zone in the pop up view. When a user selects a zone, corresponding color will be highlighted. If another color is selected for a zone, updates the zone color for that zone. http://go/scrcast/NDg2OTQ4MzI0MDg4MjE3NnxmNmE5NzY3Zi1jOQ BUG=b:265855838, b:269137429, b:265855854 TEST=browser_tests --gtest_filter='*KeyboardBacklight*' TEST=browser_tests --gtest_filter='*ZoneCustomization*' TEST=unit_tests --gtest_filter='*KeyboardBacklight*' Change-Id: Idf168ce7bd7d2d8cf2c6121e68ef84d318875355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307552 Reviewed-by:
Jason Thai <jasontt@chromium.org> Reviewed-by:
David Padlipsky <dpad@google.com> Commit-Queue: Thuong Phan <thuongphan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118949}
-
Roman Arora authored
Adds a metric that tracks for each layout which UI elements were clicked. The available UI elements at this time are: visits, suggestions, and the ShowAll button. Bug: 1414470 Change-Id: I61b06e398038acc62007673a9d8aef2d2e536deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4344089 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118948}
-
Lei Zhang authored
Emit log messages on failure to help make debugging easier. Change-Id: I8af8266ead23560ceb87490aa831a5d0de2db515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350971 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118947}
-
Evan Stade authored
Bug: 1425563 Change-Id: I4fc4300d193287fcba7785865a9010bab7f82dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4348941 Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118946}
-
Joshua Pawlicki authored
This is a reland of commit d1eb9b6e Original change's description: > Updater: Attempt to fix nondeterministic builds. > > By eliminating the copy and building directly into the bundle dir, we > avoid the undefined order of the copy vs link steps. (Note: it is not > sufficient to have the link step depend on the copy.) > > Change-Id: I043b4ddb617e94cf8eb47d4a483002fef7bed89a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4341837 > Reviewed-by:
Noah Rose Ledesma <noahrose@google.com> > Auto-Submit: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Noah Rose Ledesma <noahrose@google.com> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1118666} Change-Id: I65fa44a9f588969f0687155a3528fb8f6eda26b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4347599 Reviewed-by:
Noah Rose Ledesma <noahrose@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118945}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1679075932-e1ae64625670c743829203f372016003ca54757e.profdata to chrome-mac-arm-main-1679090008-07f6c1a242333b5a3dfc25b95b68015cc6d1ce47.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ica3be48c3ddeaf182d0820d39e7ba39c5f61eda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350376 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1118944}
-
Daniel Murphy authored
This removes some heavy includes for a file that is included by the web_app_constants.h file. There is a bug filed for further improvement to redo the Manifest::* classes to just be regular classes. Change-Id: I33025979cd78f4c05801318fb66b538b000e4f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4349869 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Dibyajyoti Pal <dibyapal@chromium.org> Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118943}
-
chromium-internal-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/fuchsia-internal-images-chromium Please CC chrome-fuchsia-gardener@grotations.appspotmail.com,chrome-fuchsia-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:fuchsia-fyi-astro Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I20aae236b4b2331168b9804227df56d0e62e4d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4349801 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1118942}
-
Juan Mojica authored
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b:273785262 Change-Id: I301b24817faaef9b5b5f12e2e4beadeb26824a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350424 Commit-Queue: Juan Mojica <juanmojica@google.com> Commit-Queue: Ali Stanfield <stanfield@google.com> Reviewed-by:
Ali Stanfield <stanfield@google.com> Auto-Submit: Juan Mojica <juanmojica@google.com> Cr-Commit-Position: refs/heads/main@{#1118941}
-
Crisrael Lucero authored
Adds new enum states for different network errors, originally added in https://chromium-review.googlesource.com/c/chromium/src/+/4074725 Change-Id: I677bac39c124d45ed9c91ff8d1cbd5c7eca7f8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4298725 Auto-Submit: Jon Mann <jonmann@chromium.org> Reviewed-by:
Abbas Nayebi <nayebi@google.com> Commit-Queue: Crisrael Lucero <crisrael@google.com> Cr-Commit-Position: refs/heads/main@{#1118940}
-
David Tseng authored
R=katie@chromium.org Change-Id: Ib945d6d6c15270de597a01ecb430fda543d6bf18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350611 Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118939}
-
sophiewen authored
This adds a threshold only in the menu, to allow for easier button presses. Test: added Fixed: b/273800202 Change-Id: I674aa87016e0e1c1b0fd60dce38ad2adce90f873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350775 Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sophie Wen <sophiewen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118938}
-
Lei Zhang authored
Replace it with a comment to explain what's going on. Change-Id: Iafc4489648f5f79984d412fba11e92159143a471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4351067 Reviewed-by:
Andy Phan <andyphan@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118937}
-
Kuan Huang authored
The test suite is not available on arm64. Bug: 1383380 Change-Id: If2bb79a9ee9c812165eaacc87448fa8fc44d8eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4348027 Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Kuan Huang <kuanhuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118936}
-
Emily Shack authored
Pulls the correct favicon for the bookmark vs only using the default favicon, in the bookmarks star entry point dialog. Also adds a white background on the favicon instead of scaling it up. Bug: 1425365 Change-Id: Ic1280ea132d9ab6ec8198de3e412b97c053332a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4348018 Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Emily Shack <emshack@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118935}
-
Marijn Kruisselbrink authored
We already have the value in a local variable, so there is no need for the second call. Change-Id: Ifbc79ee88ebcdc2c1cae3b7d2089539e6f387066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4351048 Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org> Reviewed-by:
Dibyajyoti Pal <dibyapal@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118934}
-
Xiaocheng Hu authored
This patch reimplements how we mark elements that are implicit anchors. Previously it was only marked for popover element's implicit anchors, and now it works for all implicit anchors. This is done by a new class AnchorElementObserver that observes all possible changes in implicit anchor and replaces the old PopoverAnchorObserver. This patch also reveals two existing issues: 1. Element::GetElementAttribute() may return non-null result even if the element is out of tree scope. As fixing the bug is out of the scope here, this patch just works around it. crbug.com/1425215 was filed. 2. popover-anchor-idl-property.html has some bugs that made it pass previously. This patch fixes those bugs. Fixed: 1417346 Change-Id: I798977ab1ed7df0c528b7eb98c64fc04476e6106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4338487 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118933}
-
Daniel Murphy authored
R=dibyapal@chromium.org Bug: 1329934,b/240995162 Change-Id: Ib05ff790821d441190429764694c4508a385daf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4347715 Reviewed-by:
Dibyajyoti Pal <dibyapal@chromium.org> Reviewed-by:
Duncan Mercer <mercerd@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118932}
-
Marijn Kruisselbrink authored
This should get us better debug output when the BrowserAddedWaiter times out. This is especially important before a following install_observer.Wait() call, as otherwise the test will just get killed during that wait, rather than printing the debug output that is normally printed on test failure. Change-Id: I668d3d75d736465619fd2c033b94366bcff8cd27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4351009 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118931}
-
Lei Zhang authored
- Convert most callers to WebUIDataSource::CreateAndAdd(). - Construct WebUIDataSourceImpl directly in URLDataManagerBackend. - Leave WebUIDataSource::Create() to be deleted separately. Bug: 1206140 Change-Id: Id0d39c22f2beddd9c2eeae5fb17088d4055393fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4347827 Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118930}
-
Bryant Chandler authored
HLCPP bindings had a `set_error_handler` method on the `InterfacePtr` but that's no longer available for `fidl::Client`. Instead, it takes a `fidl::AsyncEventHandler` that has an `on_fidl_error` method as well as methods for other events available on the `Protocol`. The new API shape creates quite a bit of extra boilerplate for just adding a closure or logging on fidl error (when a service is disconnected). This CL adds two basic implementations, one that just logs an error, and another that takes a callback. Bug: 1351487 Change-Id: If6ba87f24751af8daafb54904652164eb47d9875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4325064 Reviewed-by:
Guocheng Wei <guochengwei@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Bryant Chandler <bryantchandler@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118929}
-
Emily Shack authored
Bug: 1425477 Change-Id: I9e74e99ce4b7e4f8f0e14ce9de72c45e39bb2d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4348478 Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Emily Shack <emshack@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118928}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-main-1679064347-9d8f810674b9f234a3b66fd194027c63036cda16.profdata to chrome-win32-main-1679075932-cb18af2b3ad4a35200974e4031803a515e4830a1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I04f184e77c753eb802c3fc0d541394cdc8dcb4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350575 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1118927}
-
Xiaocheng Hu authored
Previously, we've been using the inset-modified containing block for position fallback, which doesn't work well with scrolling. This patch fixes the issue by using the scroll-adjusted IMCB instead, which was introduced earlier on the spec side [1]. As an implementation detail, this patch also calculates and stores the non-overflowing scroll ranges [2] for each fallback position, so that we can still use composited scrolling, and need to invalidate layout only when we have scrolled out of that range. This patch also adds WPT tests under various writing modes and directions to cover all the new code paths. [1] https://drafts4.csswg.org/css-anchor-position-1/#determine-the-position-fallback-styles [2] https://github.com/w3c/csswg-drafts/issues/8059#issuecomment-1444616906 Bug: 1418725 Change-Id: If9e104c6ac3c51ccdfc4fa7d3cf9cbffcc5af46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4292618 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118926}
-
Pilar Molina Lopez authored
VAAPI has been enabled on Lacros for a while. This CL adds vaapi unit tests to the Lacros builder. BUG=b:192563831 BUG=1425489 Change-Id: Id719f57a503b722ceec3c231e0e3b25c2fad1ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4347132 Commit-Queue: Pilar Molina Lopez <pmolinalopez@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118925}
-
Jason Hu authored
The issue occurred only when the view was scrolled down in portrait mode first. Bug: 1424933 Change-Id: I5a7951222869e7004758d3547cb0e643d571388c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4347334 Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Jason Hu <hujasonx@google.com> Cr-Commit-Position: refs/heads/main@{#1118924}
-
Ethan Jimenez authored
1. Introducing `NGGridLayoutTree`, a tree structure that holds the final track collections for the entire grid tree. In order to inherit this structure to subgrids via `NGConstraintSpace` we also introduce `NGGridLayoutSubtree`, which is a class that has the ability to access the layout tree and iterate over its nodes. 2. Removing calls to `ComputeMinMaxSizes` and `Layout` for subgrids in favor of an upcoming method that will compute the used track sizes of its standalone axis (if any). As a result of this, sizing and layout of subgrids will be incorrect until we introduce the new method. Bug: 618969 Change-Id: I26c9b2e0d49d32517b30bc710e046f0a0ee8fd07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4195814 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118923}
-
Eric Sum authored
Bug: b:271180547 Change-Id: I464ccdd071fd90954a86a72b35d3a6cf68b3cc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4308337 Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Eric Sum <esum@google.com> Cr-Commit-Position: refs/heads/main@{#1118922}
-
Anthony Carrington authored
The issue was caused from https://chromium-review.googlesource.com/c/chromium/src/+/4087385, which closes the upload dialog during focusOut events if the relatedTarget is null (which happens when the file picker is open). To fix this, we can make sure the document has focus (which it doesn't when the file picker is opened) before closing. Screencast of fix and helpful console logs: https://screencast.googleplex.com/cast/NTYzMzE3ODU1NjQzMjM4NHxmNWYyNmJkYy1iNg Bug: 1406771, b/273961108 Change-Id: I87be5930ba1bb19264af4a03140ecb24f4fe4c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4338401 Commit-Queue: Anthony Carrington <acarrington@google.com> Reviewed-by:
Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118921}
-
Ian Vollick authored
These are not currently supported on the platform. Bug: 1406229 Change-Id: I4f0a601eb2bfb58031a36b07b852b6478bef0398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350334 Reviewed-by:
Mike Taylor <miketaylr@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118920}
-
Mustafa Emre Acer authored
The bulk of the tests failing due to Https Upgrades feature have been handled in crbug.com/1424194. This CL fixes the remaining tests by allowlisting affected hostnames and enables the feature in test configs. Bug: 1394910 Change-Id: Iac5de38af86eb3f9b0f3ac5ca89386938b63200a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4312951 Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Devlin Cronin <rdevlin.cronin@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118919}
-
Lei Zhang authored
Add missing includes / remove unused includes. Then do IWYU elsewhere to fix the build. Change-Id: I025b087c211ef73171f7fd2d72ea09669639a24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4348477 Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118918}
-
Justin Novosad authored
Reimplements flaky ref tests as testharness tests. This approach avoids being dependent on the compositor's timing. Bug: 1088007 Change-Id: I726101c87c814a120f7ebc977c5d75951106505d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4347610 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118917}
-
Xiaoqian Dai authored
From the crash stack, it looks like that it might be possible that TabletModeController was not removed itself as an observer of ui::DeviceDataManager successfully when the system is suspended, which might cause a crash from TabletModeController being added as an observer twice after the system suspend is done. Bug: b/271634754 Change-Id: I66dc8ef5e1d3b2b9c238b0a75959011f02e4d727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4326944 Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118916}
-
Neil Coronado authored
Restore tab creation animation. -Prevent early animation finish. -Prevent animation values from being overridden. -Use current instead of ideal width for tab placement. Restore tab closure animation. -Prevent overriding of current tab width. Video: https://drive.google.com/file/d/1Y85E8fY1szEiaFObQPxzm8CwQZCh7JII/view?usp=share_link Bug: 1425275 Change-Id: I6d9479835235d3f8dbe8c6e739084cd2103351f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4189928 Reviewed-by:
Sirisha Kavuluru <skavuluru@google.com> Commit-Queue: Sirisha Kavuluru <skavuluru@google.com> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1118915}
-
Neil Coronado authored
Hide NTB when tab strip is empty. Bug: 1413658 Change-Id: I07779e24438e152a471ad03311a075016d75cf0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4236905 Commit-Queue: Sirisha Kavuluru <skavuluru@google.com> Reviewed-by:
Sirisha Kavuluru <skavuluru@google.com> Cr-Commit-Position: refs/heads/main@{#1118914}
-
Sophie Chang authored
Bug: b/265301309 Change-Id: Ia6b98611e0edcc8b95aa20c0ee265d5d370f96c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4347588 Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118913}
-
Kuan Huang authored
The tests are not expecting touch screen on bots, while we are using Surface Pro in win-arm64-rel pool. Bug: 1413908 Change-Id: Iaaaf73703cb4356b04692909d9a6a8e7386715df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4349440 Commit-Queue: Kuan Huang <kuanhuang@chromium.org> Reviewed-by:
Gregory Guterman <guterman@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/main@{#1118912}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3213affd36d0..1f5294f9d154 2023-03-17 brianosman@google.com Split SAA scan converter into its own file 2023-03-17 armansito@google.com [ganesh][dawn] Disable derivative uniformity warnings 2023-03-17 johnstiles@google.com Implement asin and acos in RP codegen. 2023-03-17 johnstiles@google.com Implement normalize intrinsic in RP codegen. 2023-03-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from a4cece1686a9 to 264f3ee07767 2023-03-17 johnstiles@google.com Implement reflect intrinsic in RP codegen. 2023-03-17 herb@google.com Fix undefined behavior packing top and left 2023-03-17 bungeman@google.com Add tests for SkFontMgr::matchFamilyStyle 2023-03-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 838cca34043e to 250e3914595d (2 revisions) 2023-03-17 johnstiles@google.com Implement distance intrinsic in RP codegen. 2023-03-17 johnstiles@google.com Implement asin and acos primitives in Raster Pipeline. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com,egdaniel@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I7c70cd1a6514ffaf91604cfdf9ad4d862db4fd9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350848 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1118911}
-