Remove screen dimensions from image sent with Feedback.
After speaking with the engineers on the feedback backend, I confirmed that the screen dimensions we send are ignored and instead the dimensions are pulled from the image itself. Hence this CL removes the dimensions and replaces them with a placeholder value (so that the protobuf to remain valid - without any dimensions, the server won't accept the report). This accomplishes two things, first, the hack we put in place to 'remember' the screen dimensions associated with a feedback report can now be removed. second, not requiring a browser for dimenions makes it simple to deal with the case where feedback can be invoked without a browser (as referred to in the crbug for this CL). R=asargent@chromium.org, jamescook@chromium.org, zork@chromium.org BUG=297334 Review URL: https://codereview.chromium.org/24436002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225275 0039d316-1c4b-4281-b951-d872f2087c98
Loading
Please register or sign in to comment