Skip to content
Commit eabd4d56 authored by Friedrich [CET]'s avatar Friedrich [CET] Committed by Commit Bot
Browse files

Revert "[Desktop][PwdCheck] Even icon paddings"

This reverts commit 264cfbbf.

Reason for revert: The fix seems to be worse than the problem
(see newly linked bugs).

Original change's description:
> [Desktop][PwdCheck] Even icon paddings
>
> With https://crrev.com/c/2260639, the paddings weren't distributed
> evenly anymore (start/end padding) causing misalignments.
> Additionally, the non-square icon dimensions caused rounding errors
> increasing that effect.
>
> This CL ensures consistent paddings for RTL and LTR mode. Screenshots
> are in the linked bug.
>
> Bug: 1144629
> Change-Id: Ied4af63de6d94abb2b6510cfd061a970f8f98da8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513600


> Reviewed-by: default avatarJan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823262}

TBR=jdoerrie@chromium.org,fhorschig@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1144629, 1145943, 1145931
Change-Id: Ifa4e0cd1cb705dec80968392506582c4894edd50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521512


Reviewed-by: default avatarFriedrich [CET] <fhorschig@chromium.org>
Reviewed-by: default avatarJan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824828}
parent cb56a3da
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment