Skip to content
Commit dd4efc67 authored by Christoph Schwering's avatar Christoph Schwering Committed by Chromium LUCI CQ
Browse files

[Autofill] Fixed circular dependency in driver destruction.

This CL fixes a circular dependency: ~ContentAutofillDriverFactory()
destroys ContentAutofillDriverFactory::router_ and afterwards calls
~AutofillDriverFactory(), which implicitly deletes all drivers and thus
calls ~ContentAutofillDriver(), which again refers to
ContentAutofillDriverFactory::router_.

This CL also eliminates ContentAutofillRouter::Reset() to simplify
the destruction API.

Bug: 1187842
Change-Id: I2c904292a771b757db806a24de732768251e4fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3137732


Reviewed-by: default avatarDominic Battré <battre@chromium.org>
Commit-Queue: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#918733}
parent 9ef08720
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment