Skip to content
Commit d7e2b2a0 authored by weidongliu's avatar weidongliu Committed by Chromium LUCI CQ
Browse files

Label: Use GetPreferredSize(SizeBounds) in /ash/capture_mode

GetPreferredSize() considers the currently available layout space to be
unlimited. However, for some views (eg: label), their preferred size is
strongly related to the currently available space, which leads us to
need to use GetPreferredSize() + GeHeightForWidth(), which results in
two layout calculations. It also resulted in some errors that could not
be repaired, eg: 41295639.

In the end we chose to use GetPreferredSize(SizeBounds) to solve these
problems. There is also the concept of constraint space in Blink
LayoutNG.

This CL was uploaded by git cl split.

R=afakhry@chromium.org

Bug: 40232718
Change-Id: Ic7e336c111fe064418745a0952689be0e073a444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5428652


Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
Commit-Queue: Weidong Liu <weidongliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1283519}
parent 5c727119
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment