Skip to content
Commit d2563e9c authored by Findit's avatar Findit
Browse files

Revert "Reland "Remove/replace unnecessary includes of logging.h (base/)""

This reverts commit 80b8a77a.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 780795 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzgwYjhhNzdhZTYzZGY1Nzk5Y2U3ZThhNDJmODRkODFiYTdmYjI5MmIM

Sample Failed Build: https://ci.chromium.org/b/8876777224041482672

Sample Failed Step: compile

Original change's description:
> Reland "Remove/replace unnecessary includes of logging.h (base/)"
> 
> This is a reland of a6e9e966
> 
> Original change's description:
> > Remove/replace unnecessary includes of logging.h (base/)
> >
> > If the file just needs the CHECK/CHECK_OP/NOTREACHED
> > macros, use the appropriate header for that instead.
> > Or if logging.h is not needed at all, remove it.
> >
> > This is both a nice cleanup (logging.h is a big header,
> > and including it unnecessarily has compile-time costs),
> > and part of the final step towards making logging.h no
> > longer include check.h and the others.
> >
> > TBR=thakis
> >
> > Bug: 1031540
> > Change-Id: Ib87efde411a3617fcebad6dae08313c20d63d0bd
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254284


> > Commit-Queue: Hans Wennborg <hans@chromium.org>
> > Reviewed-by: default avatarNico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#780580}
> 
> TBR=thakis
> 
> Bug: 1031540
> Change-Id: I0ba8608458cf14c3e4bbc86eaef4c7ad136a9263
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256179


> Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#780795}


Change-Id: If4ea98e6078918d097faa1d464e9b27ec497766d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1031540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256844
Cr-Commit-Position: refs/heads/master@{#780833}
parent dd758976
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment