Skip to content
Commit cc6347d0 authored by Ian Clelland's avatar Ian Clelland Committed by Chromium LUCI CQ
Browse files

Revert "[Read Anything] Define default theme from system theme"

This reverts commit c581bca3.

Reason for revert: Triggers uninitialized-memory usage on MSAN bots:

See
https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/36300

I saw an unaddressed comment about uninitialized members on PS#21, and the test failures are all in ReadAnything tests, so strongly suspecting this CL.

Original change's description:
> [Read Anything] Define default theme from system theme
>
> In this CL, we define the default theme for Read Anything from the
> system theme. If the user is on dark mode, the default theme option for
> Read Anything will be the Read Anything dark theme. For light mode, the
> default theme will be the Read Anything light theme.
>
> This CL also moves the creation of the Read Anything theme object from
> the model to the page handler. The model initializes the ColorIds for
> the themes and those are passed around as needed. When we reach the page
> handler, we will have access to the color provider (since its a View
> implementation) to convert the theme ColorIds to SKColors to make the
> theme object.
>
> Bug: 1266555
> Change-Id: Ia4a51b056a5ac3ead1a8a8395eced8ea047f5f01
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3987769


> Reviewed-by: default avatarAbigail Klein <abigailbklein@google.com>
> Commit-Queue: Jocelyn Tran <jocelyntran@google.com>
> Reviewed-by: default avatarThomas Lukaszewicz <tluk@chromium.org>
> Reviewed-by: default avatarCaroline Rising <corising@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1072314}

Bug: 1266555
Change-Id: I12c136f367c199062a6530c3f05dad94375b1618
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4031670
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Auto-Submit: Ian Clelland <iclelland@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1072421}
parent fc0bc7a8
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment