Revert "Fix Check for AAC on Windows N"
This reverts commit 705e9082. Reason for revert: MediaRecorderHandlerTest related tests, including the newly introduced `MediaRecorderHandlerIsSupportedTypeTestForMp4.CanSupportAacCodecForWinNSku`, are failing. First failing build https://ci.chromium.org/ui/p/chromium/builders/ci/win11-arm64-rel-tests/699/overview Original change's description: > Fix Check for AAC on Windows N > > In the context of Windows N SKU, the isTypeSupported function > does not include support for AAC (Advanced Audio Coding) encoding. > In standard Windows operating systems, AAC encoding relies on the > Media Foundation library. However, this library is not installed > by default in Windows N SKU, resulting in the lack of AAC encoding support. > > The straightforward solution is to check whether the system is > running Windows N SKU and return false for AAC support. > > An alternative approach involves examining the presence of > the Media Foundation binaries (such as mf.dll). Unfortunately, > this file existence check cannot be performed directly in the > renderer process. The GPU process already handles this check, > but the isTypeSupported API operates synchronously and cannot > utilize a Mojo-based solution. > > It’s worth noting that Windows N SKU is optional for European > countries and Korea, although it is not widely used. Therefore, > a simple check based on the product type could be a more effective solution. > > Bug: 329698355 > Change-Id: I00e946895d18377e87c6b8c57539184722c086f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5379757 > Reviewed-by:Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Sunggook Chue <sunggch@microsoft.com> > Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> > Reviewed-by:
Markus Handell <handellm@google.com> > Cr-Commit-Position: refs/heads/main@{#1280027} Bug: 329698355 Change-Id: I4a39781f74c4e4784fa9f3b55826823fda274cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404312 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Robert Lin <robertlin@google.com> Commit-Queue: Huanpo Lin <robertlin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1280106}
Loading
Please register or sign in to comment