Skip to content
Commit ca5380c6 authored by Ian Kilpatrick's avatar Ian Kilpatrick Committed by Chromium LUCI CQ
Browse files

Reland "[TablesNG] Fix OOF static-position of empty baseline-aligned table-cells"

This is a reland of 75216ac4

This was reverted in:
https://chromium-review.googlesource.com/c/chromium/src/+/2882605

"Reason for revert: Suspected to cause layout test failure on mac11"

However these were pre-existing layout test failures, and were present
on the mac11 bot after reverting, see:
https://ci.chromium.org/p/chromium/builders/ci/Mac11%20Tests/668

Original change's description:
> [TablesNG] Fix OOF static-position of empty baseline-aligned table-cells
>
> Alignment typically does affect the static-position of any
> OOF-positioned children inside of a table-cell. However when we are
> baseline-aligned, we should only apply the adjustment if we have
> *inflow* children.
>
> This doesn't shift the OOF-positioned children if we have no inflow
> children.
>
> Bug: 1206654
> Change-Id: I54e80831148407797354157d2c0d19afbb2a7858
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2880809


> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
> Reviewed-by: default avatarAleks Totic <atotic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#880652}

Bug: 1206654
Change-Id: Ic232f57b8feba0112693385bb2ca90d7cc8164ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2883187


Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: default avatarAleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881069}
parent 514cf4b8
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment