Skip to content
Commit c498aebc authored by Clifford Cheng's avatar Clifford Cheng Committed by Chromium LUCI CQ
Browse files

Migrate third_party/node_modules.tar.gz to GCS first class deps.

This migrates the webui_node_modules hooks to first class GCS
dependencies. See
https://chromium.googlesource.com/chromium/src.git/+/refs/heads/main/docs/gcs_dependencies.md for more info.
There are changes made in update_npm_deps to upload
nodes_modules.tar.gz and update the DEPS automatically when the
`--upload` flag is used.

src/DEPS update is refactored out of `update_node_binaries` so it can
be reused.

The current archive, `node_modules.tar.gz`, structure has changed
because of this CL. It originally has node_modules as the top level
directory, so the archive is downloaded to `src/third_party/node` and
is extracted to `src/third_party/node/node_modules`.
In order to migrate to GCS first class, `node_modules.tar.gz` needs to
be downloaded to a clean directory. So `node_modules.tar.gz` is
repacked containing only the contents under `node_modules`, excluding
top directory. It will be downloaded to
`src/third_party/node/node_modules`and will be extracted there.
This preserves the structure when extracting the archive file and
minimize the impact of the migration.

Bug: 337332463
Change-Id: Id4f228c8297ef5f12bed1ea9be46887c1df69db4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5564966


Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
Reviewed-by: default avatarJosip Sokcevic <sokcevic@chromium.org>
Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1313611}
parent 3c567b97
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment