Skip to content
Commit bba9a08e authored by Sparik Hayrapetyan's avatar Sparik Hayrapetyan Committed by Chromium LUCI CQ
Browse files

[fix-swo-violations] Fix sort comparison function

Make sure CompareDisplays comparison function is a strict weak ordering
by fixing compare(a, a) to return false.
Using a comparator which is not a strict weak ordering is undefined
behavior and crashes with _LIBCPP_DEBUG_STRICT_WEAK_ORDERING_CHECK
enabled.

Bug: None
Change-Id: I62451b22b4649f7ab34cdeeec9a36481551d9ea8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4641969


Commit-Queue: Sparik Hayrapetyan <ust@google.com>
Reviewed-by: default avatarEugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1162688}
parent cd088ff9
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment