Skip to content
Commit bafdd8b7 authored by Lei Zhang's avatar Lei Zhang Committed by Chromium LUCI CQ
Browse files

Better expose PDFiumEngine::plugin_size() callers that fail DCHECK

Use DUMP_WILL_BE_NOTREACHED() in PDFiumEngine::plugin_size() instead of
a DCHECK(), so that the DCHECK() failures consistently generate
non-fatal dumped in all builds. Temporarily un-inline plugin_size() to
avoid putting more code into the header.

Bug: 40193305
Change-Id: I92459e6d36fe33d296404486dd4b93615113a719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5618930


Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: default avatarAlan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1313170}
parent 22349ba9
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment