Skip to content
Commit ba4b65df authored by Joe Mason's avatar Joe Mason Committed by Chromium LUCI CQ
Browse files

Fix flakes in SiteDataCache tests

LevelDBSiteDataStore racily writes g_use_in_memory_db_for_testing on
the main thread and reads it on a background thread. This can cause
errors on TSAN bots. It's just coincidence that all the tests currently
have pauses that avoid a race.

SiteDataCacheFacadeBrowserTest deletes a SiteDataReader inside a
callback that the SiteDataReader invokes, while the object being
deleted is still on the stack. This can cause failures on ASAN bots.

Bug: 40755583
Change-Id: I50bc399996fe24d20ca0490579212f6f17b23b40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5426315


Reviewed-by: default avatarFrancois Pierre Doray <fdoray@chromium.org>
Auto-Submit: Joe Mason <joenotcharles@google.com>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/main@{#1283383}
parent e8bd5e27
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment