Skip to content
Commit 98405dec authored by Theo Cristea's avatar Theo Cristea Committed by Chromium LUCI CQ
Browse files

Separate `SuggestionType::kAutofillOption`, depending on filling product

This is a preliminary CL:
We want to add a new metric which would be the fieldwise version of
`Autofill.KeyMetrics.FillingAcceptance`.
The new metric will log `SuggestionType` (i.e it will record filling
acceptance grouped by `SuggestionType`).

There are already various metrics which record approximately the same
thing, but for only part of the suggestion types. The new metric will
basically unify all these already existing metrics.

`SuggestionType::kAutofillOption` can mean 4 different things at the
same time, so splitting it is necessary for the new metric to be
meaningful.

Bug: 40274514
Change-Id: I6bfd65d228dd1fe59a2aa3357d189a58f6cc1c53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5598762


Reviewed-by: default avatarAdem Derinel <derinel@google.com>
Reviewed-by: default avatarJan Keitel <jkeitel@google.com>
Reviewed-by: default avatarSergio Collazos <sczs@chromium.org>
Commit-Queue: Theo Cristea <theocristea@google.com>
Reviewed-by: default avatarTimofey Chudakov <tchudakov@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1312768}
parent a2074a14
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment