Skip to content
Commit 97a418fa authored by Cici Ruan's avatar Cici Ruan Committed by Chromium LUCI CQ
Browse files

arc/gio: fix the crash with floating window

This CL
- keeps the button options open when changing the window bounds.
- fixes the crash with the floating window. The crash happens because
  the editing list is a floating window. When exiting the fullscreen by
  creating another window, WindowState::DisableZOrdering tries to hide
  the floating window. But Game Controls (GC) tries to destroy the
  floating window when hiding the window, so the next call on the
  floating window gets nullptr crash failure. Now it removes the
  floating z-order and creates the EditingList and ButtonOptionsMenu as
  the sibling window of the InputMapping. Then EditingList and
  ButtonOptionsMenu can always stack on top of the InputMapping.
- makes the help button visible.

Bug: b/324940030
Test: manual test
Test: unit_tests --gtest_filter="*InputOverlay*:*DisplayOverlay*"
Change-Id: I48806b130b56cba1aeea99e354e0ecfd99c9360c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5394738


Reviewed-by: default avatarDavid Jacobo <djacobo@chromium.org>
Commit-Queue: Cici Ruan <cuicuiruan@google.com>
Cr-Commit-Position: refs/heads/main@{#1279908}
parent 1255cd7b
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment