Skip to content
Commit 91c1c250 authored by Antonio Sartori's avatar Antonio Sartori Committed by Chromium LUCI CQ
Browse files

Revert "[AsyncSB] Trigger CSPP ping when async check tracker has completed."

This reverts commit bf256891.

Reason for revert: Makes ExtensionTelemetryServiceBrowserTest.DetectsAndReportsTabsApiSignal flaky on ASAN, see b/345871713

Original change's description:
> [AsyncSB] Trigger CSPP ping when async check tracker has completed.
>
> When async check is enabled, RT response may not be available in
> cache_manager when the navigation is committed. This CL makes
> ClientSideDetectionHost observe AsyncCheckTracker. When
> AsyncCheckTracker notifies ClientSideDetectionHost that the check has
> completed, it is guaranteed that RT response (if any) is stored in
> cache_manager. ClientSideDetectionHost will trigger preclassification
> at this point.
>
> Add a histogram
> SBClientPhishing.ClientSideDetection.AsyncCheckTriggerForceRequestResult.
> This histogram will be useful to measure how often AsyncCheckTracker
> notifies ClientSideDetectionHost and how often the request is enforced.
>
> Bug: 342177553
> Change-Id: I2a4f672a0db9f6b38ed861ab39e2b90765cfd951
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5586037


> Reviewed-by: default avatarSeung Jae Lim <andysjlim@chromium.org>
> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1312161}

Bug: 342177553, 345871713
Change-Id: I81bd66c1dfbe1e50e6c83ed00e442cf281af94d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5615153
Auto-Submit: Antonio Sartori <antoniosartori@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Antonio Sartori <antoniosartori@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1312869}
parent bb3e6445
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment