Skip to content
Commit 8fb87aca authored by Patrick To's avatar Patrick To Committed by Chromium LUCI CQ
Browse files

Reland "Flag quads that are promoted to overlays instead of removing them"

This is a reland of Ied275829a384fdec4b2d1a3297c3d75aad5bdb0e.

This change was reverted due the candidate quad iterator being
referenced after removing the quad from the candidate list in
RemoveClearVideoQuadCandidatesIfMoving. The fix is to call
RecordDCLayerResult on the quad before removing it.

Original Change's Description:
> Quads are currently removed from the render pass's quad list when they
> are promoted to overlays. This causes extra complexity when traversing
> the quad list, since we're also removing overlay quads at the same time.
> Instead of removing them, we can mark the quads as being promoted to
> overlays and skip them in SkiaRenderer when drawing all the quads.
>
> Bug: 1444224
> Change-Id: Ib0bbf1a572d7d2476f2e33740c629451c47604b7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4519603


> Reviewed-by: default avatarSunny Sachanandani <sunnyps@chromium.org>
> Reviewed-by: default avatarKyle Charbonneau <kylechar@chromium.org>
> Reviewed-by: default avatarVasiliy Telezhnikov <vasilyt@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1145855}

Bug: 1444224
Change-Id: I4f7210bf9d5f303e4ff38bbb26997d660f72b02f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4548139


Reviewed-by: default avatarSunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Patrick To <patrto@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1147618}
parent 6ae6ceae
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment