Skip to content
Commit 87c035bc authored by Ari Chivukula's avatar Ari Chivukula Committed by Chromium LUCI CQ
Browse files

[cookies] Remove defaults from CanonicalCookie::CreateSanitizedCookie

There is a confusing pattern of defaults on cookie constructors, and
this is somewhat dangerous as we do not want cookies to be created in
production code without all values being explicitly set (especially as
new values are added). No test-only function was added given there's
only one value to add a default too it doesn't seem needed.

Bug: 332939148
Change-Id: I694660113462c19e15580fdf46564a556ba97d8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425079


Reviewed-by: default avatarDanil Somsikov <dsv@chromium.org>
Reviewed-by: default avatarMonica Basta <msalama@chromium.org>
Reviewed-by: default avatarDylan Cutler <dylancutler@google.com>
Reviewed-by: default avatarJon Mann <jonmann@chromium.org>
Reviewed-by: default avatarDanila Kuzmin <dkuzmin@google.com>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
Reviewed-by: default avatarAndrey Davydov <andreydav@google.com>
Reviewed-by: default avatarDavid Dorwin <ddorwin@chromium.org>
Reviewed-by: default avatarAyu Ishii <ayui@chromium.org>
Reviewed-by: default avatarNicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1283986}
parent 02c7febe
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment