Skip to content
Commit 83b6f724 authored by Michael Ershov's avatar Michael Ershov Committed by Chromium LUCI CQ
Browse files

Revert "Skip static animations on compositor and main"

This reverts commit 3690cd78.

Reason for revert: virtual/threaded-no-composited-antialiasing/animations 
tests started failing on multiple builders after this CL.
* https://ci.chromium.org/ui/p/chromium/builders/ci/linux-bfcache-rel
* https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests
* https://ci.chromium.org/ui/p/chromium/builders/ci/mac12-arm64-rel-tests
* https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests

Original change's description:
> Skip static animations on compositor and main
>
> An animation with empty keyframes or with keyframes whose property
> values are identical between frames previously ran as a normal
> animation. As there is no visual change other than at a phase boundary,
> these animations do not need to run on the compositor, and only need
> to be scheduled on the main thread at phase boundaries.
>
> This is the first step in optimizing no-op animations. A follow up
> patch will short-circuit sampling when the property value is constant.
> Another patch will refine the rules for background color compositing
> to only consider dynamic properties.  Finally, metrics will be added
> to track shorthand expansion of CSS properties, which is likely the
> most common source of static properties in CSS animations.
>
> Bug: 40728212
> Change-Id: I1baff2d0d26400f91f12d4cac2141e9bb101b3d0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5328026


> Reviewed-by: default avatarIan Clelland <iclelland@chromium.org>
> Reviewed-by: default avatarRobert Flack <flackr@chromium.org>
> Commit-Queue: Kevin Ellis <kevers@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1268998}

Bug: 40728212
Change-Id: Idccfa689d7a3b6e6ee9e2b6a5d109c94a4d3870b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5349489
Owners-Override: Michael Ershov <miersh@google.com>
Commit-Queue: Michael Ershov <miersh@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Michael Ershov <miersh@google.com>
Cr-Commit-Position: refs/heads/main@{#1269503}
parent 65a026d8
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment