Skip to content
Commit 8381b6e1 authored by Bence Béky's avatar Bence Béky Committed by Commit Bot
Browse files

Do not update last_activity_time_ in SpdySession::DoWriteComplete().

|last_activity_time_| is used to determine if a PING should be sent out
on an HTTP/2 connection.  The relevant measurement for this is the time
of the last read.  If |last_activity_time_| is also updated on writes,
then it is possible that a connection times out but SpdySession is not
sending any PING frames to check for this for a very long time.

This CL removes the |last_activity_time_| update from
SpdySession::DoWriteComplete(), and renames |last_activity_time_| to
|last_read_time_| to better express its function.

Bug: 784975
Change-Id: I821cc5145f44557dd3f694833314336bb21f9608
Reviewed-on: https://chromium-review.googlesource.com/779740


Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518290}
parent f13aa314
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment