Skip to content
Commit 78c2df34 authored by Robbie Gibson's avatar Robbie Gibson Committed by Chromium LUCI CQ
Browse files

[iOS] Update tests for new overflow menu

This CL makes many changes to allow tests to pass with the new ios
overflow menu feature on:
- Adds accessibility IDs to all the elements in the overflow menu as
  well as the table views.
- Disconnects the overflow menu mediator when the menu is closed to
  to prevent any observer deallocation issues.
- Many test changes to interact correctly with the new overflow menu
- Disables some multiwindow tests when the menu is enabled because
  SwiftUI, EarlGrey and Multiwindow have some bugs.

It also makes a feature change, adding a blue circle badge icon to
menu destinations when necessary.

Bugs: 1285974, 1285059
Change-Id: I8678530b49752c7c60072df699a1b03977ce566e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3365821


Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Reviewed-by: default avatarDavid Jean <djean@chromium.org>
Reviewed-by: default avatarccameron chromium <ccameron@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/main@{#959311}
parent 38ca3b9b
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment