Skip to content
Commit 750594b0 authored by Nicholas Bishop's avatar Nicholas Bishop Committed by Chromium LUCI CQ
Browse files

fwupd: Use clearer key names for flag values in message parsing

When parsing a message into a dict, uint64_t flag values are converted
to boolean flags. This is necessary because base::Value has no lossless
uint64_t type.

Previously, the key name for the boolean value was the same as the key
name for the whole flag. To make the code clearer, change the key names
for the boolean values to reflect the specific flag being stored.

BUG=none
TEST=chromeos_unittests --gtest_filter=FwupdClientTest.*

Change-Id: Ie44b2ece79d0fc9e2e76fdb5b0d4db533e7a670d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5581932


Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Commit-Queue: Nicholas Bishop <nicholasbishop@google.com>
Reviewed-by: default avatarJimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1313664}
parent 26eb5204
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment