Dismiss the bottom sheet when the orientation changes.
This is an alternate approach which relies on changes to the WindowAndroid object instead of using the configuration change method. Due to an odd interaction between elements and chrome and the bottom sheet, when the phone is rotated while a chrome feed bottom sheet menu is up, the bottom sheet menu redraws empty. To prevent that, we will dismiss the bottom sheet whenever we get a configuration change (such as a rotation) while the menu is up. This workaround will dismiss the bottom sheet for any configuration change, such as the keyboard being brought up, rotation, or screen size or layout changes, which is slight overkill. A better long term solution would be to detect the initial orientation and remember it, and only dismiss the dialog if the orientation itself changes. Another possible long term solution is to debug the interaction that makes the menu paint empty, and fix that. We have tentative approval from UX for this change. We want to get this change into M90, so if approved, we intend to cherry-pick it into the M90 branch. Bug: 1187456 Change-Id: Idbe971bcf7eac6812cea9dc52941f7ce1ef48834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2775201 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#864963}
Loading
Please register or sign in to comment