Skip to content
Commit 6ce85a09 authored by Erik Chen's avatar Erik Chen Committed by Chromium LUCI CQ
Browse files

Fix crash in LoginHandlerViews.

The destructor of WebContents can trigger
WebContentsObserver::DidFinishNavigation. This in turn can trigger the
LoginTabHelper process for showing a Loginhandler. At this point, the
WebContentsModalDialogManager has already been destroyed so the http
auth dialog can no longer be shown.

Change-Id: I5577a1d2cbeae034ad2217f1de546f459eb4885f
Bug: 328462789, 328462789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5355654


Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270490}
parent 72462779
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment