Skip to content
Commit 60afbb92 authored by John Chen's avatar John Chen Committed by Commit Bot
Browse files

Revert "[ChromeDriver] Stop using --ignore-certificate-errors"

This reverts commit 8f486945.

Reason for revert: Causing failures in WPT tests that expect certificate errors to be ignored

Original change's description:
> [ChromeDriver] Stop using --ignore-certificate-errors
> 
> ChromeDriver was passing --ignore-certificate-errors switch to Chrome,
> regardless of whether user wants to ignore certificate errors or not.
> Fixing by stop passing this flag to Chrome, and relying on using
> Security.setIgnoreCertificateErrors command when user wants to ignore
> certificate errors.
> 
> Bug: chromedriver:3148
> Change-Id: I5e8493f4cca48ebaeb211c95cd7fd645891c8659
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824005


> Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
> Commit-Queue: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#699890}

TBR=caseq@chromium.org,eseckler@chromium.org,johnchen@chromium.org

Change-Id: I01afcdbb247daade5965608926b1e2fc294cfd90
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromedriver:3148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827584


Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700239}
parent 3dd95e21
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment