Improve intentional-browser-crash identifier

If a user navigates to chrome://inducebrowsercrashforrealz then they
will, not surprisingly, crash the browser process. This has recently
been done a lot when testing the crash system on the ARM64 Windows
version of Chrome.

Unfortunately Google's crash system labels these crashes with
content::HandleDebugURL which makes it not obvious that the crash was
actually requested. And, it means that any actual crash in this function
(unlikely) would be conflated with the intentional crashes.

The fix is easy: move the crash to a separate function and tag it as
NOINLINE. The same logic applies to HangCurrentThread so I tagged it as
NOINLINE as well.

HandleDebugURL has had at least twelve bugs filed against it over the
years. Maybe this will prevent future ones.

to confirm that this change fixes the call stack.

Test: Manually crashed the browser (release build) and used the debugger
Bug: 40839653
Change-Id: Icf7ebf2b91fb4323df1da63fc86289839a03955a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5334277


Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1267177}