Skip to content
Commit 58523f90 authored by Curt Clemens's avatar Curt Clemens Committed by Chromium LUCI CQ
Browse files

Reland: [SmartLock] Rolling text animation

Original CL: crrev.com/c/3288317
Revert CL: crrev.com/c/3312798

This CL was reverted because it was failing msan tests. The variables
AnimatedAuthFactorsLabelWrapper::previous_label_id_ and
AnimatedAuthFactorsLabelWrapper::previous_accessible_name_id_ were
being compared to the new values before being initialized for the first
time. These are now initialized to zero when declared so that the
comparison is always valid.

Original CL description:
> Add an animation where changing the label text causes the old label to
> fade out and slide up while the new label fades in and slides up from
> below. Add a wrapper view to hold the label and a dummy label and
> perform the animation on them.
>
> Also set the maximum number of lines in a label to three.
>
> Animation spec:
> https://carbon.googleplex.com/cr-os-motion-work/pages/sign-in/undefined/e05c4091-eea2-4c5a-a6f8-38fd37953e7b#003cb58c-1e28-453b-a36e-7e4295058310
>
> Video (at normal speed, then slowed down to show detail):
> https://bugs.chromium.org/p/chromium/issues/attachment?aid=529495&signed_aid=NfJXnjQrnIZ-aLaCP97xzA==&inline=1

Bug: 1233614
Cq-Include-Trybots: luci.chromium.try:linux_chromium_chromeos_msan_rel_ng,linux_chromium_msan_rel_ng
Change-Id: I689f0769a245307e5d7dd92d53e9b0ce170cfba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3380390


Reviewed-by: default avatarRyan Hansberry <hansberry@chromium.org>
Reviewed-by: default avatarThomas Tellier <tellier@google.com>
Commit-Queue: Curt Clemens <cclem@google.com>
Cr-Commit-Position: refs/heads/main@{#962215}
parent 9d17aa9a
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment