Skip to content
Commit 3b257e76 authored by Zonghan Xu's avatar Zonghan Xu Committed by Chromium LUCI CQ
Browse files

Revert "[Reland 1] lens overlay: Fix context menu entry point."

This reverts commit 1095cf13.

Reason for revert: LensOverlayControllerCUJTest.OpenAndClose and . SelectManualRegion has high failure rate after the change on chromium/ci/linux-ubsan-vptr and chromium/ci/win-asan

Original change's description:
> [Reland 1] lens overlay: Fix context menu entry point.
>
> The original CL modifies a kombucha test. The modified test fails in
> ubsan builds. This appears to be a race condition in kombucha itself, as
> kombucha steps run nested by default. This reland takes all the kombucha
> steps and flushes events after every step to avoid this
> non-deterministic and racy behavior.
>
> > This CL allows us to correctly hook up the CUJ test. This CL prevents
> > lens overlay from triggering for non-normal windows.
>
> Bug: 331114227
> Change-Id: Ia2043b6df13b3b2eb8353739cae48d12f0ec4a81
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5400496


> Reviewed-by: default avatarDavid Pennington <dpenning@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1279061}

Bug: 331114227
Change-Id: I406572367021db3cb57b91382ab774343b50de85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5404550


Commit-Queue: Zonghan Xu <xzonghan@chromium.org>
Owners-Override: Zonghan Xu <xzonghan@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: default avatarZonghan Xu <xzonghan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1279863}
parent 268e7688
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment