Revert "Reland "Animate side panel opening and closing.""
This reverts commit f53300a6. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5658641195597824 Sample build with failed test: https://ci.chromium.org/b/8751715654589727745 Affected test(s): [ninja://chrome/test:interactive_ui_tests/PriceInsightsIconViewInteractiveTest.SidePanelShownOnPress](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:interactive_ui_tests%2FPriceInsightsIconViewInteractiveTest.SidePanelShownOnPress?q=VHash%3Ab13444d719a560a0) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5658641195597824&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5415398&type=BUG Original change's description: > Reland "Animate side panel opening and closing." > > This is a reland of commit 7b94b89e > > See patchset 1 vs 2 for the change. The waiter for the extension's > container side panel close button only monitored the button visibility > when it should have been monitoring the container's visibility as well. > > Original change's description: > > Animate side panel opening and closing. > > > > Create an animation that slides the side panel out from the side of the > > browser. This updates the side panel and side panel coordinator to use > > an enum, SidePanelContentState, to convey when a view should be hidden > > and allow us to delay hiding it until the side panel has been closed. > > > > Bug: 328295071 > > Change-Id: I40b099a1a3d0469ba815caf152fb0ecc3562af2f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406892 > > Commit-Queue: Caroline Rising <corising@chromium.org> > > Reviewed-by:David Pennington <dpenning@chromium.org> > > Reviewed-by:
Eshwar Stalin <estalin@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1280923} > > Bug: 328295071 > Change-Id: I64ecc52f74ade357ad8543cce98ff6daa4949c2a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5415398 > Auto-Submit: Caroline Rising <corising@chromium.org> > Reviewed-by:
David Pennington <dpenning@chromium.org> > Reviewed-by:
Eshwar Stalin <estalin@chromium.org> > Commit-Queue: David Pennington <dpenning@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1281605} > Bug: 328295071 Change-Id: I136731902de4ab4890ebbc21ff918e4927f65075 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5416687 Commit-Queue: Munira Tursunova <moonira@google.com> Owners-Override: Munira Tursunova <moonira@google.com> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1281717}
Loading
Please register or sign in to comment