Skip to content
Commit 29eeb6a0 authored by Michael Tang's avatar Michael Tang Committed by Chromium LUCI CQ
Browse files

viz: Preserve root pass remapped ID when the surface ID changes

This change preserves the root render pass' remapped ID when a surface
is cloned with a new local surface ID (LSID).

We currently preserve damage (via prev_frame_index) in the case when a
surface is cloned with a new LSID. This works well for the root surface
the output device owns the root surface. However, when
renderer_allocates_images, then the root surface will appear as an
entry in SkiaRenderer::render_pass_backings_, which is a map keyed by
render pass ID. When the LSID changes, we could end up with a frame
that assumes that content from the previous frame is still present
(via preserved damage), but we have a new root pass ID.

Change-Id: Ic55561f624f545a2f45ecc09683a2ab03c5226ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4559147


Reviewed-by: default avatarVasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Michael Tang <tangm@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1149426}
parent c46ae3d6
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment