Skip to content
Commit 2929e2e9 authored by Samuel Huang's avatar Samuel Huang Committed by Chromium LUCI CQ
Browse files

[Optimization Guide Internals] Add filtering.

This CL adds to chrome://optimization-guide-internals/ data table
filtering by applying optional "include" and "exclude" text matches to
each row to determine whether it should be shown or hidden.
* Add "Include" and "Exclude" text boxes for filter texts.
  * For each row, check {"Log source", "Source Location", "Log Message"}
    cells separately for matches.
    * Underlying selection logic: <td> under <th class="filterable">.
  * Matching: Case-sensitive substring search.
  * Hide a row if the following hold:
    * If "exclude" text is non-empty, any match.
    * If "include" text is non-empty, no match.
* Filtering is triggered by "include" / "exclude" input changes (thus
  avoiding the need for a "Filter" button).
  * To reduce churn, each input change triggers a 500ms timer, after
    which global filtering is applied. Timers are coalesced.
* Filters are applied to new rows as they appear.
* Render "shown rows / total rows" stats.

Bug: 329133014
Change-Id: Ie99ddaaeee58de2fdc103397c51b57eeea718681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5353915


Reviewed-by: default avatarTibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: default avatarSophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1271857}
parent dc046dfa
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment