Skip to content
Commit 2639e68b authored by Benedikt Meurer's avatar Benedikt Meurer Committed by Chromium LUCI CQ
Browse files

[DevTools] Propagate keyboard shortcuts in native menus.

The DevTools front-end already passes a `shortcut` field as part of the
`ShowContextMenuItem`, but the Chromium back-end never paid attention to
this field until now. With this change, we thread through the shortcut
all the way to the `RenderViewContextMenuBase` and put it as the minor
text for menu items.

Screenshot: https://i.imgur.com/8mFJsWM.png
Doc: https://goo.gle/devtools-consistent-context-menus
Change-Id: I4ce3b13f8c2445c6b658c3445af68344fde6a64d
Bug: 330213829
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5489020


Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: default avatarDanil Somsikov <dsv@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304296}
parent 45d1bd7f
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment