Skip to content
Commit 1f5957ab authored by mark a. foltz's avatar mark a. foltz Committed by Chromium LUCI CQ
Browse files

[Frame Sink Capture] Refactor frame sink capture for better tracing.

This CL refactors the way frame data is passed through the frame sink
capturer to prevent video frame metadata from being dropped on the
floor if a step fails in the process.

It also simplifies the way per-frame data is tracked by:
- Using a single object to track per-frame data throughout the process
- Keeping track of the outcome of a capture (success or failure reason)
- So that downstream code can query that status, instead of checking for
  a null-frame.

Fixed: 335353377
Change-Id: I4f0d0f1fbb0557f50e8a87f2366eb0b718960173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5606100


Reviewed-by: default avatarIlya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: default avatarPiotr Bialecki <bialpio@chromium.org>
Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1312961}
parent eaa2076d
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment