Skip to content
Commit 0f4a28aa authored by Ryo Hashimoto's avatar Ryo Hashimoto Committed by Chromium LUCI CQ
Browse files

Revert "Fix jank on first show of holding space welcome banner."

This reverts commit f5df79ec.

Reason for revert: Breaks filemanager.DragDrop tast and blocks chrome uprev.

Original change's description:
> Fix jank on first show of holding space welcome banner.
>
> Because holding space welcome banner styles are dynamically loaded,
> there was some jank when the banner was shown before the dynamic styles
> had finished loading.
>
> This CL adds inline styles to hide the welcome banner until they are
> removed following load completion of dynamic styles.
>
> Bug: 1170470
> Change-Id: I32aa65c5c17505d1e2c2bee61a4e27468c6f881d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2649110


> Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
> Commit-Queue: David Black <dmblack@google.com>
> Cr-Commit-Position: refs/heads/master@{#847408}

TBR=dmblack@google.com,lucmult@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1171875
Bug: 1170470
Change-Id: Ie71d01fcf37776d8fe0c66b66e465aa690050eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2663348


Reviewed-by: default avatarRyo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#849091}
parent 739d1af1
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment