Skip to content
Commit 0266cecb authored by Orin Jaworski's avatar Orin Jaworski Committed by Chromium LUCI CQ
Browse files

[omnibox] Fix verbatim sequence matching & all known pedals batch3 bugs

This CL fixes a few issues where pedals implementations went out of
sync with the UX spec (one URL and two sign-in-state requirements).

It also fixes verbatim sequence matching by expanding the token
dictionary to include any tokens in verbatim sequences taken from
pedal button labels. Previously, pedal matching would fail as soon
as any unrecognized token was found, and button labels sometimes
validly contain tokens not initially present in the token dictionary.

Lastly, it enables all 'en-GB' batch3 pedals, copying finalized
triggering data from 'en'.

Bug: 893183
Change-Id: I95c28e47db223a24753362a1e523e6a88c04e6bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206544


Reviewed-by: default avatarmanuk hovanesian <manukh@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#928891}
parent 426a1337
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment