Skip to content
Commit c24c5910 authored by Greg Kurz's avatar Greg Kurz Committed by Michael Roth
Browse files

virtfs: error out gracefully when mandatory suboptions are missing



We internally convert -virtfs to -fsdev/-device. If the user doesn't
provide the path or security_model suboptions, and the fsdev backend
requires them, we hit an assertion when populating the internal -fsdev
option:

util/qemu-option.c:547: opt_set: Assertion `opt->str' failed.
Aborted (core dumped)

Let's test the suboption presence on the command line before trying
to set it in the internal -fsdev option, and let the backend code
error out gracefully (ie, like it already does when the user passes
-fsdev on the command line).

Reported-by: default avatarThomas Huth <thuth@redhat.com>
Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
(cherry picked from commit 32b69436)
Signed-off-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
parent 2d1bbf51
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment