Skip to content
Commit 6130c462 authored by Laszlo Ersek's avatar Laszlo Ersek Committed by Michael Roth
Browse files

hw/core: rebase sysbus_get_fw_dev_path() to g_strdup_printf()



This is done mainly for improving readability, and in preparation for the
next patch, but Markus pointed out another bonus for the string being
returned:

"No arbitrary length limit. Before the patch, it's 39 characters, and the
code breaks catastrophically when qdev_fw_name() is longer: the second
snprintf() is called with its first argument pointing beyond path[], and
its second argument underflowing to a huge size."

Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarLaszlo Ersek <lersek@redhat.com>
Tested-by: default avatarMarcel Apfelbaum <marcel@redhat.com>
Reviewed-by: default avatarMarcel Apfelbaum <marcel@redhat.com>
Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 5ba03e2d)
Signed-off-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
parent 49ef542e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment