Skip to content
Commit 3ae74003 authored by Eric Blake's avatar Eric Blake Committed by Michael Roth
Browse files

blkdebug: Simplify override logic



Rather than store into a local variable, then copy to the struct
if the value is valid, then reporting errors otherwise, it is
simpler to just store into the struct and report errors if the
value is invalid.  This however requires that the struct store
a 64-bit number, rather than a narrower type.  Likewise, setting
a sane errno value in ret prior to the sequence of parsing and
jumping to out: on error makes it easier for the next patch to
add a chain of similar checks.

Signed-off-by: default avatarEric Blake <eblake@redhat.com>
Message-id: 20170429191419.30051-8-eblake@redhat.com
Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
(cherry picked from commit 3dc834f8)
* prereq for 81c219ac
Signed-off-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
parent 577cf9e6
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment