Skip to content
  1. Jul 14, 2018
    • Linus Torvalds's avatar
      Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · aa0a3247
      Linus Torvalds authored
      Pull perf tool fixes from Ingo Molnar:
       "Misc tooling fixes: python3 related fixes, gcc8 fix, bashism fixes and
        some other smaller fixes"
      
      * 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        perf tools: Use python-config --includes rather than --cflags
        perf script python: Fix dict reference counting
        perf stat: Fix --interval_clear option
        perf tools: Fix compilation errors on gcc8
        perf test shell: Prevent temporary editor files from being considered test scripts
        perf llvm-utils: Remove bashism from kernel include fetch script
        perf test shell: Make perf's inet_pton test more portable
        perf test shell: Replace '|&' with '2>&1 |' to work with more shells
        perf scripts python: Add Python 3 support to EventClass.py
        perf scripts python: Add Python 3 support to sched-migration.py
        perf scripts python: Add Python 3 support to Util.py
        perf scripts python: Add Python 3 support to SchedGui.py
        perf scripts python: Add Python 3 support to Core.py
        perf tools: Generate a Python script compatible with Python 2 and 3
      aa0a3247
    • Linus Torvalds's avatar
      Merge branch 'efi-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 75adbd13
      Linus Torvalds authored
      Pull EFI fix from Ingo Molnar:
       "Fix a UEFI mixed mode (64-bit kernel on 32-bit UEFI) reboot loop
        regression"
      
      * 'efi-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        efi/x86: Fix mixed mode reboot loop by removing pointless call to PciIo->Attributes()
      75adbd13
    • Linus Torvalds's avatar
      Merge branch 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · ae4ea397
      Linus Torvalds authored
      Pull rseq fixes from Ingo Molnar:
       "Various rseq ABI fixes and cleanups: use get_user()/put_user(),
        validate parameters and use proper uapi types, etc"
      
      * 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        rseq/selftests: cleanup: Update comment above rseq_prepare_unload
        rseq: Remove unused types_32_64.h uapi header
        rseq: uapi: Declare rseq_cs field as union, update includes
        rseq: uapi: Update uapi comments
        rseq: Use get_user/put_user rather than __get_user/__put_user
        rseq: Use __u64 for rseq_cs fields, validate user inputs
      ae4ea397
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma · 4659fc84
      Linus Torvalds authored
      Pull rdma fixes from Jason Gunthorpe:
       "Things have been quite slow, only 6 RC patches have been sent to the
        list. Regression, user visible bugs, and crashing fixes:
      
         - cxgb4 could wrongly fail MR creation due to a typo
      
         - various crashes if the wrong QP type is mixed in with APIs that
           expect other types
      
         - syzkaller oops
      
         - using ERR_PTR and NULL together cases HFI1 to crash in some cases
      
         - mlx5 memory leak in error unwind"
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma:
        RDMA/mlx5: Fix memory leak in mlx5_ib_create_srq() error path
        RDMA/uverbs: Don't fail in creation of multiple flows
        IB/hfi1: Fix incorrect mixing of ERR_PTR and NULL return values
        RDMA/uverbs: Fix slab-out-of-bounds in ib_uverbs_ex_create_flow
        RDMA/uverbs: Protect from attempts to create flows on unsupported QP
        iw_cxgb4: correctly enforce the max reg_mr depth
      4659fc84
    • Linus Torvalds's avatar
      Merge tag 'vfio-v4.18-rc5' of git://github.com/awilliam/linux-vfio · 2a7e1211
      Linus Torvalds authored
      Pull VFIO fix from Alex Williamson:
       "Fix deadlock in mbochs sample driver (Alexey Khoroshilov)"
      
      * tag 'vfio-v4.18-rc5' of git://github.com/awilliam/linux-vfio:
        sample: vfio-mdev: avoid deadlock in mdev_access()
      2a7e1211
    • Linus Torvalds's avatar
      Merge tag 'kbuild-fixes-v4.18-2' of... · 79facf30
      Linus Torvalds authored
      Merge tag 'kbuild-fixes-v4.18-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
      
      Pull Kbuild fixes from Masahiro Yamada:
      
       - update Kbuild and Kconfig documents
      
       - sanitize -I compiler option handling
      
       - update extract-vmlinux script to recognize LZ4 and ZSTD
      
       - fix tools Makefiles
      
       - update tags.sh to handle __ro_after_init
      
       - suppress warnings in case getconf does not recognize LFS_* parameters
      
      * tag 'kbuild-fixes-v4.18-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild:
        kbuild: suppress warnings from 'getconf LFS_*'
        scripts/tags.sh: add __ro_after_init
        tools: build: Use HOSTLDFLAGS with fixdep
        tools: build: Fixup host c flags
        tools build: fix # escaping in .cmd files for future Make
        scripts: teach extract-vmlinux about LZ4 and ZSTD
        kbuild: remove duplicated comments about PHONY
        kbuild: .PHONY is not a variable, but PHONY is
        kbuild: do not drop -I without parameter
        kbuild: document the KBUILD_KCONFIG env. variable
        kconfig: update user kconfig tools doc.
        kbuild: delete INSTALL_FW_PATH from kbuild documentation
        kbuild: update ARCH alias info for sparc
        kbuild: update ARCH alias info for sh
      79facf30
    • Linus Torvalds's avatar
      Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux · 9d2e3489
      Linus Torvalds authored
      Pull arm64 fixes from Will Deacon:
       "Catalin's out enjoying the sunshine, so I'm sending the fixes for a
        couple of weeks (although there hopefully won't be any more!).
      
        We've got a revert of a previous fix because it broke the build with
        some distro toolchains and a preemption fix when detemining whether or
        not the SIMD unit is in use.
      
        Summary:
      
         - Revert back to the 'linux' target for LD, as 'elf' breaks some
           distributions
      
         - Fix preemption race when testing whether the vector unit is in use
           or not"
      
      * tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux:
        arm64: neon: Fix function may_use_simd() return error status
        Revert "arm64: Use aarch64elf and aarch64elfb emulation mode variants"
      9d2e3489
    • Linus Torvalds's avatar
      Merge branch 'fixes' of git://git.armlinux.org.uk/~rmk/linux-arm · e6ef7607
      Linus Torvalds authored
      Pull ARM fixes from Russell King:
       "A couple of small fixes this time around from Steven for an
        interaction between ftrace and kernel read-only protection, and
        Vladimir for nommu"
      
      * 'fixes' of git://git.armlinux.org.uk/~rmk/linux-arm:
        ARM: 8780/1: ftrace: Only set kernel memory back to read-only after boot
        ARM: 8775/1: NOMMU: Use instr_sync instead of plain isb in common code
      e6ef7607
    • Linus Torvalds's avatar
      Merge tag 'trace-v4.18-rc3-3' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace · 35a84f34
      Linus Torvalds authored
      Pull tracing fixlet from Steven Rostedt:
       "Joel Fernandes asked to add a feature in tracing that Android had its
        own patch internally for. I took it back in 4.13. Now he realizes that
        he had a mistake, and swapped the values from what Android had. This
        means that the old Android tools will break when using a new kernel
        that has the new feature on it.
      
        The options are:
      
         1. To swap it back to what Android wants.
         2. Add a command line option or something to do the swap
         3. Just let Android carry a patch that swaps it back
      
        Since it requires setting a tracing option to enable this anyway, I
        doubt there are other users of this than Android. Thus, I've decided
        to take option 1. If someone else is actually depending on the order
        that is in the kernel, then we will have to revert this change and go
        to option 2 or 3"
      
      * tag 'trace-v4.18-rc3-3' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace:
        tracing: Reorder display of TGID to be after PID
      35a84f34
    • Linus Torvalds's avatar
      Merge tag 'sound-4.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound · a0092e5e
      Linus Torvalds authored
      Pull sound fixes from Takashi Iwai:
       "Just a few HD-auio fixes: one fix for a possible mutex deadlock at
        HDMI hotplug handling is somewhat subtle and delicate, while the rest
        are usual device-specific quirks"
      
      * tag 'sound-4.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound:
        ALSA: hda/ca0132: Update a pci quirk device name
        ALSA: hda/ca0132: Add Recon3Di quirk for Gigabyte G1.Sniper Z97
        ALSA: hda/realtek - two more lenovo models need fixup of MIC_LOCATION
        ALSA: hda - Handle pm failure during hotplug
      a0092e5e
    • Linus Torvalds's avatar
      Merge tag 'libnvdimm-fixes-4.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm · 4596f554
      Linus Torvalds authored
      Pull libnvdimm fixes from Dave Jiang:
      
       - ensure that a variable passed in by reference to acpi_nfit_ctl is
         always set to a value. An incremental patch is provided due to notice
         from testing in -next. The rest of the commits did not exhibit
         issues.
      
       - fix a return path in nsio_rw_bytes() that was not returning "bytes
         remain" as expected for the function.
      
       - address an issue where applications polling on scrub-completion for
         the NVDIMM may falsely wakeup and read the wrong state value and
         cause hang.
      
       - change the test unit persistent capability attribute to fix up a
         broken assumption in the unit test infrastructure wrt the
         'write_cache' attribute
      
       - ratelimit dev_info() in the dax device check_vma() function since
         this is easily triggered from userspace
      
      * tag 'libnvdimm-fixes-4.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm:
        nfit: fix unchecked dereference in acpi_nfit_ctl
        acpi, nfit: Fix scrub idle detection
        tools/testing/nvdimm: advertise a write cache for nfit_test
        acpi/nfit: fix cmd_rc for acpi_nfit_ctl to always return a value
        dev-dax: check_vma: ratelimit dev_info-s
        libnvdimm, pmem: Fix memcpy_mcsafe() return code handling in nsio_rw_bytes()
      4596f554
  2. Jul 13, 2018
    • Joel Fernandes (Google)'s avatar
      tracing: Reorder display of TGID to be after PID · f8494fa3
      Joel Fernandes (Google) authored
      Currently ftrace displays data in trace output like so:
      
                                             _-----=> irqs-off
                                            / _----=> need-resched
                                           | / _---=> hardirq/softirq
                                           || / _--=> preempt-depth
                                           ||| /     delay
                  TASK-PID   CPU    TGID   ||||    TIMESTAMP  FUNCTION
                     | |       |      |    ||||       |         |
                  bash-1091  [000] ( 1091) d..2    28.313544: sched_switch:
      
      However Android's trace visualization tools expect a slightly different
      format due to an out-of-tree patch patch that was been carried for a
      decade, notice that the TGID and CPU fields are reversed:
      
                                             _-----=> irqs-off
                                            / _----=> need-resched
                                           | / _---=> hardirq/softirq
                                           || / _--=> preempt-depth
                                           ||| /     delay
                  TASK-PID    TGID   CPU   ||||    TIMESTAMP  FUNCTION
                     | |        |      |   ||||       |         |
                  bash-1091  ( 1091) [002] d..2    64.965177: sched_switch:
      
      From kernel v4.13 onwards, during which TGID was introduced, tracing
      with systrace on all Android kernels will break (most Android kernels
      have been on 4.9 with Android patches, so this issues hasn't been seen
      yet). From v4.13 onwards things will break.
      
      The chrome browser's tracing tools also embed the systrace viewer which
      uses the legacy TGID format and updates to that are known to be
      difficult to make.
      
      Considering this, I suggest we make this change to the upstream kernel
      and backport it to all Android kernels. I believe this feature is merged
      recently enough into the upstream kernel that it shouldn't be a problem.
      Also logically, IMO it makes more sense to group the TGID with the
      TASK-PID and the CPU after these.
      
      Link: http://lkml.kernel.org/r/20180626000822.113931-1-joel@joelfernandes.org
      
      Cc: jreck@google.com
      Cc: tkjos@google.com
      Cc: stable@vger.kernel.org
      Fixes: 441dae8f
      
       ("tracing: Add support for display of tgid in trace output")
      Signed-off-by: default avatarJoel Fernandes (Google) <joel@joelfernandes.org>
      Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
      f8494fa3
    • Linus Torvalds's avatar
      Merge tag 'mtd/fixes-for-4.18-rc5' of git://git.infradead.org/linux-mtd · 63f04777
      Linus Torvalds authored
      Pull MTD fix from Boris Brezillon:
       "A SPI NOR fix to fix a timeout in the cadence QSPI controller driver"
      
      * tag 'mtd/fixes-for-4.18-rc5' of git://git.infradead.org/linux-mtd:
        mtd: spi-nor: cadence-quadspi: Fix direct mode write timeouts
      63f04777
  3. Jul 12, 2018
    • Masahiro Yamada's avatar
      kbuild: suppress warnings from 'getconf LFS_*' · 6d79a7b4
      Masahiro Yamada authored
      Suppress warnings for systems that do not recognize LFS_*.
      
       getconf: no such configuration parameter `LFS_CFLAGS'
       getconf: no such configuration parameter `LFS_LDFLAGS'
       getconf: no such configuration parameter `LFS_LIBS'
      
      Fixes: d7f14c66
      
       ("kbuild: Enable Large File Support for hostprogs")
      Reported-by: default avatarChen Feng <puck.chen@hisilicon.com>
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      6d79a7b4
    • Constantine Shulyupin's avatar
    • Laura Abbott's avatar
      tools: build: Use HOSTLDFLAGS with fixdep · 8b247a92
      Laura Abbott authored
      
      
      The final link of fixdep uses LDFLAGS but not the existing HOSTLDFLAGS.
      Fix this.
      
      Signed-off-by: default avatarLaura Abbott <labbott@redhat.com>
      Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      8b247a92
    • Laura Abbott's avatar
      tools: build: Fixup host c flags · 6fdbd824
      Laura Abbott authored
      Commit 0c3b7e42 ("tools build: Add support for host programs format")
      introduced host_c_flags which referenced CHOSTFLAGS. The actual name of the
      variable is HOSTCFLAGS. Fix this up.
      
      Fixes: 0c3b7e42
      
       ("tools build: Add support for host programs format")
      Signed-off-by: default avatarLaura Abbott <labbott@redhat.com>
      Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      6fdbd824
    • Paul Menzel's avatar
      tools build: fix # escaping in .cmd files for future Make · 9feeb638
      Paul Menzel authored
      In 2016 GNU Make made a backwards incompatible change to the way '#'
      characters were handled in Makefiles when used inside functions or
      macros:
      
      http://git.savannah.gnu.org/cgit/make.git/commit/?id=c6966b323811c37acedff05b57
      
      Due to this change, when attempting to run `make prepare' I get a
      spurious make syntax error:
      
          /home/earnest/linux/tools/objtool/.fixdep.o.cmd:1: *** missing separator.  Stop.
      
      When inspecting `.fixdep.o.cmd' it includes two lines which use
      unescaped comment characters at the top:
      
          \# cannot find fixdep (/home/earnest/linux/tools/objtool//fixdep)
          \# using basic dep data
      
      This is because `tools/build/Build.include' prints these '\#'
      characters:
      
          printf '\# cannot find fixdep (%s)\n' $(fixdep) > $(dot-target).cmd; \
          printf '\# using basic dep data\n\n' >> $(dot-target).cmd;           \
      
      This completes commit 9564a8cf
      
       ("Kbuild: fix # escaping in .cmd files
      for future Make").
      
      Link: https://bugzilla.kernel.org/show_bug.cgi?id=197847
      Cc: Randy Dunlap <rdunlap@infradead.org>
      Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarPaul Menzel <pmenzel@molgen.mpg.de>
      Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
      9feeb638
    • Ingo Molnar's avatar
      Merge tag 'perf-urgent-for-mingo-4.18-20180711' of... · 6e1d33b2
      Ingo Molnar authored
      
      Merge tag 'perf-urgent-for-mingo-4.18-20180711' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent
      
      Pull perf/urgent fixes from Arnaldo Carvalho de Melo:
      
      python interface fixes:
      
      - Make 'perf script -g python' generate scripts that are compatible
        with both python 2 and 3 (Jeremy Cline)
      
      - Fix python dictionary reference counting (Janne Huttunen)
      
      - Add python3 support for various python scripts (Jeremy Cline)
      
      - Use python-config --includes rather than --cflags, fixing the build
        on Fedora, where the python 3.7 started adding -flto to what
      
      perf stat fixes:
      
        - Remove needless extra header line in --interval_clear (Jiri Olsa)
        python-config --cflags generate, breaking the perf build (Jeremy Cline)
      
      Build fixes:
      
      - Fix compilation errors on gcc8 (Jiri Olsa)
      
      perf llvm-utils fixes:
      
      - Remove bashism from kernel include fetch script (Kim Phillips)
      
      perf test fixes: (Kim Phillips)
      
      - Replace '|&' with '2>&1 |' to work with more shells
      
      - Make perf's inet_pton test more portable
      
      - Prevent temporary editor files from being considered test scripts
      
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
      6e1d33b2
    • Alastair Bridgewater's avatar
      ALSA: hda/ca0132: Update a pci quirk device name · c5a59d24
      Alastair Bridgewater authored
      
      
      The PCI subsystem in question for this quirk rule has been
      identified as a Gigabyte GA-Z170X-Gaming 7 motherboard.  Set the
      device name appropriately.
      
      Signed-off-by: default avatarAlastair Bridgewater <alastair.bridgewater@gmail.com>
      Reviewed-by: default avatarConnor McAdams <conmanx360@gmail.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      c5a59d24
    • Alastair Bridgewater's avatar
      ALSA: hda/ca0132: Add Recon3Di quirk for Gigabyte G1.Sniper Z97 · dad59262
      Alastair Bridgewater authored
      
      
      These motherboards have Sound Core3D and apparently "support"
      Recon3Di.  Added to the quirk list as QUIRK_R3DI.
      
      Issue report, PCI Subsystem ID, and testing by a contributor on
      IRC who wished to remain anonymous.
      
      Signed-off-by: default avatarAlastair Bridgewater <alastair.bridgewater@gmail.com>
      Reviewed-by: default avatarConnor McAdams <conmanx360@gmail.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      dad59262
    • Steven Rostedt (VMware)'s avatar
      ARM: 8780/1: ftrace: Only set kernel memory back to read-only after boot · b4c7e2bd
      Steven Rostedt (VMware) authored
      Dynamic ftrace requires modifying the code segments that are usually
      set to read-only. To do this, a per arch function is called both before
      and after the ftrace modifications are performed. The "before" function
      will set kernel code text to read-write to allow for ftrace to make the
      modifications, and the "after" function will set the kernel code text
      back to "read-only" to keep the kernel code text protected.
      
      The issue happens when dynamic ftrace is tested at boot up. The test is
      done before the kernel code text has been set to read-only. But the
      "before" and "after" calls are still performed. The "after" call will
      change the kernel code text to read-only prematurely, and other boot
      code that expects this code to be read-write will fail.
      
      The solution is to add a variable that is set when the kernel code text
      is expected to be converted to read-only, and make the ftrace "before"
      and "after" calls do nothing if that variable is not yet set. This is
      similar to the x86 solution from commit 16239630
      
       ("ftrace, x86:
      make kernel text writable only for conversions").
      
      Link: http://lkml.kernel.org/r/20180620212906.24b7b66e@vmware.local.home
      
      Reported-by: default avatarStefan Agner <stefan@agner.ch>
      Tested-by: default avatarStefan Agner <stefan@agner.ch>
      Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
      Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
      b4c7e2bd
    • Kamal Heib's avatar
      RDMA/mlx5: Fix memory leak in mlx5_ib_create_srq() error path · d63c4673
      Kamal Heib authored
      Fix memory leak in the error path of mlx5_ib_create_srq() by making sure
      to free the allocated srq.
      
      Fixes: c2b37f76
      
       ("IB/mlx5: Fix integer overflows in mlx5_ib_create_srq")
      Signed-off-by: default avatarKamal Heib <kamalheib1@gmail.com>
      Acked-by: default avatarLeon Romanovsky <leonro@mellanox.com>
      Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
      d63c4673
    • Linus Torvalds's avatar
      Merge tag 'trace-v4.18-rc3-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace · c25c74b7
      Linus Torvalds authored
      Pull kprobe fix from Steven Rostedt:
       "This fixes a memory leak in the kprobe code"
      
      * tag 'trace-v4.18-rc3-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace:
        tracing/kprobe: Release kprobe print_fmt properly
      c25c74b7
    • Jiri Olsa's avatar
      tracing/kprobe: Release kprobe print_fmt properly · 0fc8c358
      Jiri Olsa authored
      We don't release tk->tp.call.print_fmt when destroying
      local uprobe. Also there's missing print_fmt kfree in
      create_local_trace_kprobe error path.
      
      Link: http://lkml.kernel.org/r/20180709141906.2390-1-jolsa@kernel.org
      
      Cc: stable@vger.kernel.org
      Fixes: e12f03d7
      
       ("perf/core: Implement the 'perf_kprobe' PMU")
      Acked-by: default avatarSong Liu <songliubraving@fb.com>
      Acked-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
      0fc8c358
    • Linus Torvalds's avatar
      Merge branch 'for-4.18-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata · 86125df7
      Linus Torvalds authored
      Pull libata fixes from Tejun Heo:
      
       - Jens's patches to expand the usable command depth from 31 to 32 broke
         sata_fsl due to a subtle command iteration bug. Fixed by introducing
         explicit iteration helpers and using the correct variant.
      
       - On some laptops, enabling LPM by default reportedly led to occasional
         hard hangs. Blacklist the affected cases.
      
       - Other misc fixes / changes.
      
      * 'for-4.18-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata:
        ata: Remove depends on HAS_DMA in case of platform dependency
        ata: Fix ZBC_OUT all bit handling
        ata: Fix ZBC_OUT command block check
        ahci: Add Intel Ice Lake LP PCI ID
        ahci: Disable LPM on Lenovo 50 series laptops with a too old BIOS
        sata_nv: remove redundant pointers sdev0 and sdev1
        sata_fsl: remove dead code in tag retrieval
        sata_fsl: convert to command iterator
        libata: convert eh to command iterators
        libata: add command iterator helpers
        ata: ahci_mvebu: ahci_mvebu_stop_engine() can be static
        libahci: Fix possible Spectre-v1 pmp indexing in ahci_led_store()
      86125df7
    • Alexey Khoroshilov's avatar
      sample: vfio-mdev: avoid deadlock in mdev_access() · 498e8bf5
      Alexey Khoroshilov authored
      
      
      mdev_access() calls mbochs_get_page() with mdev_state->ops_lock held,
      while mbochs_get_page() locks the mutex by itself.
      It leads to unavoidable deadlock.
      
      Found by Linux Driver Verification project (linuxtesting.org).
      
      Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
      Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
      498e8bf5
    • Dave Jiang's avatar
      nfit: fix unchecked dereference in acpi_nfit_ctl · ee6581ce
      Dave Jiang authored
      Incremental patch to fix the unchecked dereference in acpi_nfit_ctl.
      Reported by Dan Carpenter:
      
      "acpi/nfit: fix cmd_rc for acpi_nfit_ctl to
      always return a value" from Jun 28, 2018, leads to the following
      Smatch complaint:
      
          drivers/acpi/nfit/core.c:578 acpi_nfit_ctl()
           warn: variable dereferenced before check 'cmd_rc' (see line 411)
      
      drivers/acpi/nfit/core.c
         410
         411		*cmd_rc = -EINVAL;
                      ^^^^^^^^^^^^^^^^^^
      Patch adds unchecked dereference.
      
      Fixes: c1985cef
      
       ("acpi/nfit: fix cmd_rc for acpi_nfit_ctl to always return a value")
      
      Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
      ee6581ce
    • Linus Torvalds's avatar
      Merge tag 'char-misc-4.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc · a74aa967
      Linus Torvalds authored
      Pull char/misc fixes from Greg KH:
       "Here are a few char/misc driver fixes for 4.18-rc5.
      
        The "largest" stuff here is fixes for the UIO changes in 4.18-rc1 that
        caused breakages for some people. Thanks to Xiubo Li for fixing them
        quickly. Other than that, minor fixes for thunderbolt, vmw_balloon,
        nvmem, mei, ibmasm, and mei drivers. There's also a MAINTAINERS update
        where Rafael is offering to help out with reviewing driver core
        patches.
      
        All of these have been in linux-next with no reported issues"
      
      * tag 'char-misc-4.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc:
        nvmem: Don't let a NULL cell_id for nvmem_cell_get() crash us
        thunderbolt: Notify userspace when boot_acl is changed
        uio: fix crash after the device is unregistered
        uio: change to use the mutex lock instead of the spin lock
        uio: use request_threaded_irq instead
        fpga: altera-cvp: Fix an error handling path in 'altera_cvp_probe()'
        ibmasm: don't write out of bounds in read handler
        MAINTAINERS: Add myself as driver core changes reviewer
        mei: discard messages from not connected client during power down.
        vmw_balloon: fix inflation with batching
      a74aa967
    • Linus Torvalds's avatar
      Merge tag 'staging-4.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging · 1dc85ac2
      Linus Torvalds authored
      Pull staging fixes from Greg KH:
       "Here are two tiny staging driver fixes for reported issues for
        4.18-rc5.
      
        One fixes the r8822be driver to properly work on lots of new laptops,
        the other is for the rtl8723bs driver to fix an underflow error.
      
        Both have been in linux-next for a while with no reported issues"
      
      * tag 'staging-4.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging:
        staging: r8822be: Fix RTL8822be can't find any wireless AP
        staging: rtl8723bs: Prevent an underflow in rtw_check_beacon_data().
      1dc85ac2
    • Linus Torvalds's avatar
      Merge tag 'usb-4.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb · 24d5b287
      Linus Torvalds authored
      Pull USB fixes from Greg KH:
       "Here are a number of small USB fixes for 4.18-rc5.
      
        Nothing major here, just the normal set of new device ids, xhci fixes,
        and some typec fixes. The typec fix required some tiny changes in an
        i2c driver, which that maintainer acked to come through my tree.
      
        All of these have been in linux-next for a while with no reported
        issues"
      
      * tag 'usb-4.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb:
        USB: yurex: fix out-of-bounds uaccess in read handler
        usb: quirks: add delay quirks for Corsair Strafe
        xhci: xhci-mem: off by one in xhci_stream_id_to_ring()
        usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency
        docs: kernel-parameters.txt: document xhci-hcd.quirks parameter
        USB: serial: mos7840: fix status-register error handling
        USB: serial: keyspan_pda: fix modem-status error handling
        USB: serial: cp210x: add another USB ID for Qivicon ZigBee stick
        USB: serial: ch341: fix type promotion bug in ch341_control_in()
        i2c-cht-wc: Fix bq24190 supplier
        typec: tcpm: Correctly report power_supply current and voltage for non pd supply
        usb: xhci: dbc: Don't decrement runtime PM counter if DBC is not started
      24d5b287
    • Linus Torvalds's avatar
      Merge tag 'mmc-v4.18-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc · f1454959
      Linus Torvalds authored
      Pull MMC fixes from Ulf Hansson:
       "MMC core:
         - Fixup devname in /proc/interrupts for card detect GPIO
      
        MMC host:
         - sdhci-esdhc-imx: Allow 1.8V speed-modes without 100/200MHz pinctrls
         - sunxi: Disable IRQ in low power state to prevent IRQ storm
         - dw_mmc: Fix card threshold control configuration
         - renesas_sdhi_internal_dmac: Fixup DMA error paths"
      
      * tag 'mmc-v4.18-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc:
        mmc: sdhci-esdhc-imx: allow 1.8V modes without 100/200MHz pinctrl states
        mmc: sunxi: Disable irq during pm_suspend
        mmc: dw_mmc: fix card threshold control configuration
        mmc: core: cd_label must be last entry of mmc_gpio struct
        mmc: renesas_sdhi_internal_dmac: Cannot clear the RX_IN_USE in abort
        mmc: renesas_sdhi_internal_dmac: Fix missing unmap in error patch
      f1454959
    • Linus Torvalds's avatar
      Merge tag 'acpi-4.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm · 5d580932
      Linus Torvalds authored
      Pull ACPI fix from Rafael Wysocki:
       "Address a regression in ACPICA that ceased to clear the status of GPEs
        and fixed events before entering the ACPI S5 (off) system state during
        the 4.17 cycle which caused some systems to power up immediately after
        they had been turned off"
      
      * tag 'acpi-4.18-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm:
        ACPICA: Clear status of all events when entering S5
      5d580932
    • Yandong Zhao's avatar
      arm64: neon: Fix function may_use_simd() return error status · 2fd8eb4a
      Yandong Zhao authored
      It does not matter if the caller of may_use_simd() migrates to
      another cpu after the call, but it is still important that the
      kernel_neon_busy percpu instance that is read matches the cpu the
      task is running on at the time of the read.
      
      This means that raw_cpu_read() is not sufficient.  kernel_neon_busy
      may appear true if the caller migrates during the execution of
      raw_cpu_read() and the next task to be scheduled in on the initial
      cpu calls kernel_neon_begin().
      
      This patch replaces raw_cpu_read() with this_cpu_read() to protect
      against this race.
      
      Cc: <stable@vger.kernel.org>
      Fixes: cb84d11e
      
       ("arm64: neon: Remove support for nested or hardirq kernel-mode NEON")
      Acked-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
      Reviewed-by: default avatarDave Martin <Dave.Martin@arm.com>
      Reviewed-by: default avatarMark Rutland <mark.rutland@arm.com>
      Signed-off-by: default avatarYandong Zhao <yandong77520@gmail.com>
      Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
      2fd8eb4a
  4. Jul 11, 2018
    • Jeremy Cline's avatar
      perf tools: Use python-config --includes rather than --cflags · 32aa928a
      Jeremy Cline authored
      Builds started failing in Fedora on Python 3.7 with:
      
          `.gnu.debuglto_.debug_macro' referenced in section
          `.gnu.debuglto_.debug_macro' of
          util/scripting-engines/trace-event-python.o: defined in discarded
          section
      
      In Fedora, Python 3.7 added -flto to the list of --cflags and since it
      was only applied to util/scripting-engines/trace-event-python.c and
      scripts/python/Perf-Trace-Util/Context.c, linking failed.
      
      It's not the first time the addition of flags has broken builds: commit
      c6707fde
      
       ("perf tools: Fix up build in hardnened environments")
      appears to have fixed a similar problem. "python-config --includes"
      provides the proper -I flags and doesn't introduce additional CFLAGS.
      
      Signed-off-by: default avatarJeremy Cline <jcline@redhat.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lkml.kernel.org/r/20180710154612.6285-1-jcline@redhat.com
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      32aa928a
    • Janne Huttunen's avatar
      perf script python: Fix dict reference counting · db0ba84c
      Janne Huttunen authored
      
      
      The dictionaries are attached to the parameter tuple that steals the
      references and takes care of releasing them when appropriate.  The code
      should not decrement the reference counts explicitly.  E.g. if libpython
      has been built with reference debugging enabled, the superfluous DECREFs
      will trigger this error when running perf script:
      
        Fatal Python error: Objects/tupleobject.c:238 object at
        0x7f10f2041b40 has negative ref count -1
        Aborted (core dumped)
      
      If the reference debugging is not enabled, the superfluous DECREFs might
      cause the dict objects to be silently released while they are still in
      use. This may trigger various other assertions or just cause perf
      crashes and/or weird and unexpected data changes in the stored Python
      objects.
      
      Signed-off-by: default avatarJanne Huttunen <janne.huttunen@nokia.com>
      Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
      Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Andi Kleen <ak@linux.intel.com>
      Cc: Jaroslav Skarvada <jskarvad@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lkml.kernel.org/r/1531133990-17485-1-git-send-email-janne.huttunen@nokia.com
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      db0ba84c
    • Jiri Olsa's avatar
      perf stat: Fix --interval_clear option · c818cc06
      Jiri Olsa authored
      
      
      Currently we display extra header line, like:
      
        # perf stat -I 1000 -a --interval-clear
        #           time             counts unit events
               insn per cycle branch-misses of all branches
             2.964917103        3855.349912      cpu-clock (msec)          #    3.855 CPUs utilized
             2.964917103             23,993      context-switches          #    0.006 M/sec
             2.964917103              1,301      cpu-migrations            #    0.329 K/sec
             ...
      
      Fixing the condition and getting proper:
      
        # perf stat -I 1000 -a --interval-clear
        #           time             counts unit events
             2.359048938        1432.492228      cpu-clock (msec)          #    1.432 CPUs utilized
             2.359048938              7,613      context-switches          #    0.002 M/sec
             2.359048938                419      cpu-migrations            #    0.133 K/sec
             ...
      
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Fixes: 9660e08e
      
       ("perf stat: Add --interval-clear option")
      Link: http://lkml.kernel.org/r/20180702134202.17745-2-jolsa@kernel.org
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      c818cc06
    • Jiri Olsa's avatar
      perf tools: Fix compilation errors on gcc8 · a09603f8
      Jiri Olsa authored
      
      
      We are getting following warnings on gcc8 that break compilation:
      
        $ make
          CC       jvmti/jvmti_agent.o
        jvmti/jvmti_agent.c: In function ‘jvmti_open’:
        jvmti/jvmti_agent.c:252:35: error: ‘/jit-’ directive output may be truncated \
          writing 5 bytes into a region of size between 1 and 4096 [-Werror=format-truncation=]
          snprintf(dump_path, PATH_MAX, "%s/jit-%i.dump", jit_path, getpid());
      
      There's no point in checking the result of snprintf call in
      jvmti_open, the following open call will fail in case the
      name is mangled or too long.
      
      Using tools/lib/ function scnprintf that touches the return value from
      the snprintf() calls and thus get rid of those warnings.
      
        $ make DEBUG=1
          CC       arch/x86/util/perf_regs.o
        arch/x86/util/perf_regs.c: In function ‘arch_sdt_arg_parse_op’:
        arch/x86/util/perf_regs.c:229:4: error: ‘strncpy’ output truncated before terminating nul
        copying 2 bytes from a string of the same length [-Werror=stringop-truncation]
          strncpy(prefix, "+0", 2);
          ^~~~~~~~~~~~~~~~~~~~~~~~
      
      Using scnprintf instead of the strncpy (which we know is safe in here)
      to get rid of that warning.
      
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: http://lkml.kernel.org/r/20180702134202.17745-1-jolsa@kernel.org
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      a09603f8
    • Kim Phillips's avatar
      perf test shell: Prevent temporary editor files from being considered test scripts · db8fec58
      Kim Phillips authored
      
      
      Allows a perf shell test developer to concurrently edit and run their
      test scripts, avoiding perf test attempts to execute their editor
      temporary files, such as seen here:
      
       $ sudo taskset -c 0 ./perf test -vvvvvvvv -F 63
       63: 0VIM 8.0                                              :
       --- start ---
       sh: 1: ./tests/shell/.record+probe_libc_inet_pton.sh.swp: Permission denied
       ---- end ----
       0VIM 8.0: FAILED!
      
      Signed-off-by: default avatarKim Phillips <kim.phillips@arm.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Michael Petlan <mpetlan@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Sandipan Das <sandipan@linux.vnet.ibm.com>
      Cc: Thomas Richter <tmricht@linux.vnet.ibm.com>
      Link: http://lkml.kernel.org/r/20180629124658.15a506b41fc4539c08eb9426@arm.com
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      db8fec58
    • Kim Phillips's avatar
      perf llvm-utils: Remove bashism from kernel include fetch script · f6432b9f
      Kim Phillips authored
      
      
      Like system(), popen() calls /bin/sh, which may/may not be bash.
      
      Script when run on dash and encounters the line, yields:
      
       exit: Illegal number: -1
      
      checkbashisms report on script content:
      
       possible bashism (exit|return with negative status code):
       exit -1
      
      Remove the bashism and use the more portable non-zero failure
      status code 1.
      
      Signed-off-by: default avatarKim Phillips <kim.phillips@arm.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Michael Petlan <mpetlan@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Sandipan Das <sandipan@linux.vnet.ibm.com>
      Cc: Thomas Richter <tmricht@linux.vnet.ibm.com>
      Link: http://lkml.kernel.org/r/20180629124652.8d0af7e2281fd3fd8262cacc@arm.com
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      f6432b9f