Skip to content
Commit f2c0d026 authored by Jonathan Nieder's avatar Jonathan Nieder Committed by Linus Torvalds
Browse files

cap_syslog: don't use WARN_ONCE for CAP_SYS_ADMIN deprecation warning



syslog-ng versions before 3.3.0beta1 (2011-05-12) assume that
CAP_SYS_ADMIN is sufficient to access syslog, so ever since CAP_SYSLOG
was introduced (2010-11-25) they have triggered a warning.

Commit ee24aebf ("cap_syslog: accept CAP_SYS_ADMIN for now")
improved matters a little by making syslog-ng work again, just keeping
the WARN_ONCE().  But still, this is a warning that writes a stack trace
we don't care about to syslog, sets a taint flag, and alarms sysadmins
when nothing worse has happened than use of an old userspace with a
recent kernel.

Convert the WARN_ONCE to a printk_once to avoid that while continuing to
give userspace developers a hint that this is an unwanted
backward-compatibility feature and won't be around forever.

Reported-by: default avatarRalf Hildebrandt <ralf.hildebrandt@charite.de>
Reported-by: default avatarNiels <zorglub_olsen@hotmail.com>
Reported-by: default avatarPaweł Sikora <pluto@agmk.net>
Signed-off-by: default avatarJonathan Nieder <jrnieder@gmail.com>
Liked-by: default avatarGergely Nagy <algernon@madhouse-project.org>
Acked-by: default avatarSerge Hallyn <serge@hallyn.com>
Acked-by: default avatarJames Morris <jmorris@namei.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9f50fad6
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment