Skip to content
Commit 95bf9d64 authored by Eric W. Biederman's avatar Eric W. Biederman
Browse files

signal/mips: Update (_save|_restore)_fp_context to fail with -EFAULT

When an instruction to save or restore a register from the stack fails
in _save_fp_context or _restore_fp_context return with -EFAULT.  This
change was made to r2300_fpu.S[1] but it looks like it got lost with
the introduction of EX2[2].  This is also what the other implementation
of _save_fp_context and _restore_fp_context in r4k_fpu.S does, and
what is needed for the callers to be able to handle the error.

Furthermore calling do_exit(SIGSEGV) from bad_stack is wrong because
it does not terminate the entire process it just terminates a single
thread.

As the changed code was the only caller of arch/mips/kernel/syscall.c:bad_stack
remove the problematic and now unused helper function.

Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Maciej Rozycki <macro@orcam.me.uk>
Cc: linux-mips@vger.kernel.org
[1] 35938a00 ("MIPS: Fix ISA I FP sigcontext access violation handling")
[2] f92722dc ("MIPS: Correct MIPS I FP sigcontext layout")
Cc: stable@vger.kernel.org
Fixes: f92722dc

 ("MIPS: Correct MIPS I FP sigcontext layout")
Acked-by: default avatarMaciej W. Rozycki <macro@orcam.me.uk>
Acked-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
Link: https://lkml.kernel.org/r/20211020174406.17889-5-ebiederm@xmission.com
Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
parent 97cae848
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment