Skip to content
Commit 7032269e authored by Chris Ball's avatar Chris Ball Committed by Jiri Kosina
Browse files

HID: hiddev: protect against disconnect/NULL-dereference race



One of our users reports consistently hitting a NULL dereference that
resolves to the "hid_to_usb_dev(hid);" call in hiddev_ioctl(), when
disconnecting a Lego WeDo USB HID device from an OLPC XO running
Scratch software.  There's a FIXME comment and a guard against the
dereference, but that happens farther down the function than the
initial dereference does.

This patch moves the call to be below the guard, and the user reports
that it fixes the problem for him.  OLPC bug report:
http://dev.laptop.org/ticket/10174

Signed-off-by: default avatarChris Ball <cjb@laptop.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 1778ca29
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment