Skip to content
Commit 66259146 authored by Lv Zheng's avatar Lv Zheng Committed by Rafael J. Wysocki
Browse files

ACPI / EC: Drop EC noirq hooks to fix a regression

According to bug reports, although the busy polling mode can make
noirq stages execute faster, it causes abnormal fan blowing up after
system resume (see the first link below for a video demonstration)
on Lenovo ThinkPad X1 Carbon - the 5th Generation.  The problem can
be fixed by upgrading the EC firmware on that machine.

However, many reporters confirm that the problem can be fixed by
stopping busy polling during suspend/resume and for some of them
upgrading the EC firmware is not an option.

For this reason, drop the noirq stage hooks from the EC driver
to fix the regression.

Fixes: c3a696b6 (ACPI / EC: Use busy polling mode when GPE is not enabled)
Link: https://youtu.be/9NQ9x-Jm99Q
Link: https://bugzilla.kernel.org/show_bug.cgi?id=196129


Reported-by: default avatarAndreas Lindhe <andreas@lindhe.io>
Tested-by: default avatarGjorgji Jankovski <j.gjorgji@gmail.com>
Tested-by: default avatarDamjan Georgievski <gdamjan@gmail.com>
Tested-by: default avatarFernando Chaves <nanochaves@gmail.com>
Tested-by: default avatarTomislav Ivek <tomislav.ivek@gmail.com>
Tested-by: default avatarDenis P. <theoriginal.skullburner@gmail.com>
Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent ef75040a
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment