Skip to content
Commit 526f5b85 authored by Junwei Hu's avatar Junwei Hu Committed by David S. Miller
Browse files

tipc: fix modprobe tipc failed after switch order of device registration



Error message printed:
modprobe: ERROR: could not insert 'tipc': Address family not
supported by protocol.
when modprobe tipc after the following patch: switch order of
device registration, commit 7e27e8d6
("tipc: switch order of device registration to fix a crash")

Because sock_create_kern(net, AF_TIPC, ...) called by
tipc_topsrv_create_listener() in the initialization process
of tipc_init_net(), so tipc_socket_init() must be execute before that.
Meanwhile, tipc_net_id need to be initialized when sock_create()
called, and tipc_socket_init() is no need to be called for each namespace.

I add a variable tipc_topsrv_net_ops, and split the
register_pernet_subsys() of tipc into two parts, and split
tipc_socket_init() with initialization of pernet params.

By the way, I fixed resources rollback error when tipc_bcast_init()
failed in tipc_init_net().

Fixes: 7e27e8d6 ("tipc: switch order of device registration to fix a crash")
Signed-off-by: default avatarJunwei Hu <hujunwei4@huawei.com>
Reported-by: default avatarWang Wang <wangwang2@huawei.com>
Reported-by: default avatar <syzbot+1e8114b61079bfe9cbc5@syzkaller.appspotmail.com>
Reviewed-by: default avatarKang Zhou <zhoukang7@huawei.com>
Reviewed-by: default avatarSuanming Mou <mousuanming@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f49aa1de
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment