Skip to content
Commit 42383020 authored by Sage Weil's avatar Sage Weil Committed by Chris Mason
Browse files

Btrfs: fix race in WAIT_SYNC ioctl



We check whether transid is already committed via last_trans_committed and
then search through trans_list for pending transactions.  If
last_trans_committed is updated by btrfs_commit_transaction after we check
it (there is no locking), we will fail to find the committed transaction
and return EINVAL to the caller.  This has been observed occasionally by
ceph-osd (which uses this ioctl heavily).

Fix by rechecking whether the provided transid <= last_trans_committed
after the search fails, and if so return 0.

Signed-off-by: default avatarSage Weil <sage@redhat.com>
Signed-off-by: default avatarChris Mason <clm@fb.com>
parent 656f30db
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment