Skip to content
Commit 3dc289f8 authored by Anant Thazhemadam's avatar Anant Thazhemadam Committed by Johannes Berg
Browse files

net: wireless: nl80211: fix out-of-bounds access in nl80211_del_key()



In nl80211_parse_key(), key.idx is first initialized as -1.
If this value of key.idx remains unmodified and gets returned, and
nl80211_key_allowed() also returns 0, then rdev_del_key() gets called
with key.idx = -1.
This causes an out-of-bounds array access.

Handle this issue by checking if the value of key.idx after
nl80211_parse_key() is called and return -EINVAL if key.idx < 0.

Cc: stable@vger.kernel.org
Reported-by: default avatar <syzbot+b1bb342d1d097516cbda@syzkaller.appspotmail.com>
Tested-by: default avatar <syzbot+b1bb342d1d097516cbda@syzkaller.appspotmail.com>
Signed-off-by: default avatarAnant Thazhemadam <anant.thazhemadam@gmail.com>
Link: https://lore.kernel.org/r/20201007035401.9522-1-anant.thazhemadam@gmail.com


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent d91dc434
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment